Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7399)

Unified Diff: chrome/browser/spellchecker/spellchecker_session_bridge_android.h

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellchecker_session_bridge_android.h
diff --git a/chrome/browser/spellchecker/spellchecker_session_bridge_android.h b/chrome/browser/spellchecker/spellchecker_session_bridge_android.h
deleted file mode 100644
index 42fb75bb1506e055b4fd6e1a65cda2eb2b755aac..0000000000000000000000000000000000000000
--- a/chrome/browser/spellchecker/spellchecker_session_bridge_android.h
+++ /dev/null
@@ -1,65 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_ANDROID_H_
-#define CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_ANDROID_H_
-
-#include <jni.h>
-
-#include <memory>
-
-#include "base/android/scoped_java_ref.h"
-#include "base/macros.h"
-#include "base/strings/string16.h"
-
-// A class used to interface between the Java class of the same name and the
-// android message filter. This class receives text to be spellchecked
-// from the message filter, sends that text to the Java side via JNI to be
-// spellchecked, and then sends those results to the renderer.
-class SpellCheckerSessionBridge {
- public:
- explicit SpellCheckerSessionBridge(int render_process_id);
- ~SpellCheckerSessionBridge();
- static bool RegisterJNI(JNIEnv* env);
-
- // Receives text to be checked from the message filter and sends it to Java
- // to be spellchecked.
- void RequestTextCheck(int route_id,
- int identifier,
- const base::string16& text);
-
- // Receives information from Java side about the typos in a given string
- // of text, processes these and sends them to the renderer.
- void ProcessSpellCheckResults(
- JNIEnv* env,
- const base::android::JavaParamRef<jobject>& jobj,
- const base::android::JavaParamRef<jintArray>& offset_array,
- const base::android::JavaParamRef<jintArray>& length_array);
-
- // Sets the handle to the Java SpellCheckerSessionBridge object to null,
- // marking the Java object for garbage collection.
- void DisconnectSession();
-
- private:
- struct SpellingRequest {
- SpellingRequest(int route_id, int identifier, const base::string16& text);
- ~SpellingRequest();
-
- int route_id;
- int identifier;
- base::string16 text;
- };
-
- int render_process_id_;
-
- std::unique_ptr<SpellingRequest> active_request_;
- std::unique_ptr<SpellingRequest> pending_request_;
-
- base::android::ScopedJavaGlobalRef<jobject> java_object_;
- bool java_object_initialization_failed_;
-
- DISALLOW_COPY_AND_ASSIGN(SpellCheckerSessionBridge);
-};
-
-#endif // CHROME_BROWSER_SPELLCHECKER_SPELLCHECKER_SESSION_BRIDGE_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698