Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/spellchecker/word_trimmer_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc
diff --git a/chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc b/chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc
index 069ae0ecc55500b18a9f756cf80ae16f43456164..549250de6bd80c94243064bb7fd2e7f3e8a2e69d 100644
--- a/chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc
+++ b/chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc
@@ -12,6 +12,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/prefs/pref_service.h"
+#include "components/spellcheck/browser/pref_names.h"
MultilanguageOptionsBrowserTest::MultilanguageOptionsBrowserTest() {
}
@@ -35,11 +36,12 @@ void MultilanguageOptionsBrowserTest::SetUpOnMainThread() {
base::ListValue dictionaries;
dictionaries.AppendString("fr");
SetDictionariesPref(dictionaries);
- browser()->profile()->GetPrefs()->SetString(prefs::kSpellCheckDictionary,
- std::string());
+ browser()->profile()->GetPrefs()->SetString(
Lei Zhang 2016/08/16 15:42:57 Maybe same the pointer from GetPrefs() on line 35
timvolodine 2016/08/16 18:19:15 Done.
+ spellcheck::prefs::kSpellCheckDictionary, std::string());
}
void MultilanguageOptionsBrowserTest::SetDictionariesPref(
const base::ListValue& value) {
- browser()->profile()->GetPrefs()->Set(prefs::kSpellCheckDictionaries, value);
+ browser()->profile()->GetPrefs()->Set(
+ spellcheck::prefs::kSpellCheckDictionaries, value);
}
« no previous file with comments | « chrome/browser/spellchecker/word_trimmer_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698