components/spellcheck/browser/spellcheck_host_metrics_unittest.cc - Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/spellcheck/browser/spellcheck_host_metrics_unittest.cc

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more cleanup Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc ('K') | « components/spellcheck/browser/spellcheck_host_metrics.cc ('k') | components/spellcheck/browser/spellcheck_message_filter_platform.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h"	5 #include "components/spellcheck/browser/spellcheck_host_metrics.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include <memory>	9 #include <memory>

10	10

11 #include "base/macros.h"	11 #include "base/macros.h"

12 #include "base/message_loop/message_loop.h"	12 #include "base/message_loop/message_loop.h"

13 #include "base/metrics/histogram_samples.h"	13 #include "base/metrics/histogram_samples.h"

14 #include "base/metrics/statistics_recorder.h"	14 #include "base/metrics/statistics_recorder.h"

15 #include "base/strings/utf_string_conversions.h"	15 #include "base/strings/utf_string_conversions.h"

(...skipping 91 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
107	107

108 histogram_tester1.ExpectBucketCount(kMetricName, 0, 1);	108 histogram_tester1.ExpectBucketCount(kMetricName, 0, 1);

109 histogram_tester1.ExpectBucketCount(kMetricName, 1, 0);	109 histogram_tester1.ExpectBucketCount(kMetricName, 1, 0);

110	110

111 base::HistogramTester histogram_tester2;	111 base::HistogramTester histogram_tester2;

112	112

113 metrics()->RecordSpellingServiceStats(true);	113 metrics()->RecordSpellingServiceStats(true);

114 histogram_tester2.ExpectBucketCount(kMetricName, 0, 0);	114 histogram_tester2.ExpectBucketCount(kMetricName, 0, 0);

115 histogram_tester2.ExpectBucketCount(kMetricName, 1, 1);	115 histogram_tester2.ExpectBucketCount(kMetricName, 1, 1);

116 }	116 }

OLD	NEW