components/spellcheck/browser/spellcheck_action_unittest.cc - Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/spellcheck/browser/spellcheck_action_unittest.cc

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more cleanup Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc ('K') | « components/spellcheck/browser/spellcheck_action.cc ('k') | components/spellcheck/browser/spellcheck_dictionary.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/spellchecker/spellcheck_action.h"	5 #include "components/spellcheck/browser/spellcheck_action.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include <memory>	9 #include <memory>

10 #include <string>	10 #include <string>

11	11

12 #include "base/json/json_reader.h"	12 #include "base/json/json_reader.h"

13 #include "base/macros.h"	13 #include "base/macros.h"

14 #include "base/strings/utf_string_conversions.h"	14 #include "base/strings/utf_string_conversions.h"

15 #include "base/values.h"	15 #include "base/values.h"

(...skipping 75 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91 "{\"actionTargetIndex\": 42, \"actionType\": \"SELECT\"}" },	91 "{\"actionTargetIndex\": 42, \"actionType\": \"SELECT\"}" },

92 };	92 };

93 for (size_t i = 0; i < kNumTestCases; ++i) {	93 for (size_t i = 0; i < kNumTestCases; ++i) {

94 std::unique_ptr<base::DictionaryValue> serialized(	94 std::unique_ptr<base::DictionaryValue> serialized(

95 kTestCases[i].action.Serialize());	95 kTestCases[i].action.Serialize());

96 std::unique_ptr<base::Value> expected =	96 std::unique_ptr<base::Value> expected =

97 base::JSONReader::Read(kTestCases[i].expected);	97 base::JSONReader::Read(kTestCases[i].expected);

98 EXPECT_TRUE(serialized->Equals(expected.get()));	98 EXPECT_TRUE(serialized->Equals(expected.get()));

99 }	99 }

100 }	100 }

OLD	NEW