Add command to run earlgrey tests upstream.

Add command to run earlgrey tests upstream.

The upstream bots are still xcode 7, so iossim will not work for them.  
Change to the previous version to use xcodebuild
BUG=

Committed: https://chromium.googlesource.com/chromium/tools/build/+/1aa280064119546863fd9bfd25d06cb0b2743329

[huangml1, 2016-08-12 23:43:40]

huangml@chromium.org changed reviewers:
+ huangml@chromium.org, smut@google.com

[huangml1, 2016-08-12 23:44:27]

Description was changed from

==========
Add command to run earlgrey tests upstream.

BUG=
==========

to

==========
Add command to run earlgrey tests upstream.

The upstream bots are still xcode 7, so iossim will not work for them.  Change
to the previous version to use xcodebuild
BUG=
==========

[huangml1, 2016-08-12 23:44:34]

Description was changed from

==========
Add command to run earlgrey tests upstream.

The upstream bots are still xcode 7, so iossim will not work for them.  Change
to the previous version to use xcodebuild
BUG=
==========

to

==========
Add command to run earlgrey tests upstream.

The upstream bots are still xcode 7, so iossim will not work for them.  
Change to the previous version to use xcodebuild
BUG=
==========

[smut, 2016-08-12 23:45:35]

lgtm % comment

https://codereview.chromium.org/2244053002/diff/1/scripts/slave/ios/test_runn...
File scripts/slave/ios/test_runner.py (right):

https://codereview.chromium.org/2244053002/diff/1/scripts/slave/ios/test_runn...
scripts/slave/ios/test_runner.py:1278: cmd=''
You don't need this initialization since you define cmd in both the if and else
code paths. Also this is the wrong initialization anyways since cmd is expected
to be a list.

[huangml1, 2016-08-12 23:48:09]

The CQ bit was checked by huangml@chromium.org

[huangml1, 2016-08-12 23:48:10]

The patchset sent to the CQ was uploaded after l-g-t-m from smut@google.com
Link to the patchset: https://codereview.chromium.org/2244053002/#ps20001
(title: "Remove unnessary initialization")

[commit-bot: I haz the power, 2016-08-12 23:48:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 23:52:32]

Description was changed from

==========
Add command to run earlgrey tests upstream.

The upstream bots are still xcode 7, so iossim will not work for them.  
Change to the previous version to use xcodebuild
BUG=
==========

to

==========
Add command to run earlgrey tests upstream.

The upstream bots are still xcode 7, so iossim will not work for them.  
Change to the previous version to use xcodebuild
BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/1aa280064119546863fd...
==========

[commit-bot: I haz the power, 2016-08-12 23:52:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/1aa280064119546863fd...

[baxley, 2016-08-15 18:17:34]

baxley@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2016-08-15 18:17:34]

https://codereview.chromium.org/2244053002/diff/20001/scripts/slave/ios/test_...
File scripts/slave/ios/test_runner.py (right):

https://codereview.chromium.org/2244053002/diff/20001/scripts/slave/ios/test_...
scripts/slave/ios/test_runner.py:1278: if self.xcode_version == '8.0':
How long do we expect this to be in place?

If the old code goes away when Xcode 8 is GM and installed everywhere, then I
think there should be a bug tracking that we remove the old code.

If this will be long lived to always support both versions, should we change the
condition to be > 8.0?

[smut, 2016-08-15 18:57:53]

https://codereview.chromium.org/2244053002/diff/20001/scripts/slave/ios/test_...
File scripts/slave/ios/test_runner.py (right):

https://codereview.chromium.org/2244053002/diff/20001/scripts/slave/ios/test_...
scripts/slave/ios/test_runner.py:1278: if self.xcode_version == '8.0':
On 2016/08/15 18:17:34, baxley wrote:
> How long do we expect this to be in place?
> 
> If the old code goes away when Xcode 8 is GM and installed everywhere, then I
> think there should be a bug tracking that we remove the old code.
> 
> If this will be long lived to always support both versions, should we change
the
> condition to be > 8.0?

Ideally we should remove it when Xcode 8 is used by all the bots because they'll
never go back to not-Xcode 8, but we haven't always done that in practice. I
think there is still an instance of explicit Xcode 5 support somewhere in this
file.