Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2244043002: Fix instantiateToBounds behavior in summary resynthesizer to match that of StrongTypeSystemImpl.ins… (Closed)

Created:
4 years, 4 months ago by Paul Berry
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix instantiateToBounds behavior in summary resynthesizer to match that of StrongTypeSystemImpl.instantiateToBounds. Note that StrongTypeSystemImpl.instantiateToBounds misbehaves if the bound on one type parameter refers to a later type parameter. I'm not sure what the intended behavior is in this case, so I've filed dartbug.com/27072. Once that is fixed we can refine the behavior of the summary resynthesizer further. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/058dd73f1d75ed97c9e57230704315dc847402ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +17 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_strong_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 4 months ago (2016-08-12 23:43:13 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-13 00:27:44 UTC) #3
Paul Berry
4 years, 4 months ago (2016-08-13 00:29:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
058dd73f1d75ed97c9e57230704315dc847402ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698