Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 224403003: Disable two tests with syntax errors that v8 wants to enforce. (Closed)

Created:
6 years, 8 months ago by ncarter (slow)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/external_extension_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mallinath (Gone from Chromium)
lgtm
6 years, 8 months ago (2014-04-03 19:54:50 UTC) #1
bungeman-chromium
lgtm, so long as we get the bugs assigned to the right people.
6 years, 8 months ago (2014-04-03 19:58:29 UTC) #2
ncarter (slow)
6 years, 8 months ago (2014-04-03 20:55:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r261521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698