Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2244023003: Fix broken git tests on mac. (Closed)

Created:
4 years, 4 months ago by iannucci
Modified:
4 years, 4 months ago
Reviewers:
agable, Nico
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix broken git tests on mac. Unfortunately there's a bunch of other broken stuff, but it's something :/ R=agable@chromium.org, thakis@chromium.org BUG=607344 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e38699bd9583c2ee9eb1436f3fc640cf97462722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M git_common.py View 1 chunk +7 lines, -5 lines 0 comments Download
M testing_support/git_test_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/git_common_test.py View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
iannucci
4 years, 4 months ago (2016-08-13 02:42:13 UTC) #1
agable
lgtm
4 years, 4 months ago (2016-08-15 16:26:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244023003/1
4 years, 4 months ago (2016-08-16 00:29:28 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 00:32:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e38699bd9583c2...

Powered by Google App Engine
This is Rietveld 408576698