Fix bugs with SPEC2k for WebAssembly

Fix bugs with SPEC2k for WebAssembly

NOPRESUBMIT=true

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/090f907ce9b3d4300b6273d89598f7dfb23bbfd7

[ddchen, 2016-08-12 23:15:12]

ddchen@chromium.org changed reviewers:
+ dschuff@chromium.org

[ddchen, 2016-08-12 23:15:13]

This is the first set of fixes.

[Derek Schuff, 2016-08-15 17:57:45]

https://codereview.chromium.org/2244023002/diff/40001/tests/spec2k/197.parser...
File tests/spec2k/197.parser/diff (right):

https://codereview.chromium.org/2244023002/diff/40001/tests/spec2k/197.parser...
tests/spec2k/197.parser/diff:9: int strncasecmp(const char *s1, const char *s2,
size_t);
This declaration is the same as the one for strncasecmp in strings.h. Is it
necessary to ifdef the declaration too? i.e. can we get away with just ifdefing
the definition? (Or is emscripten's header declaration different?)

[ddchen, 2016-08-16 04:58:52]

https://codereview.chromium.org/2244023002/diff/40001/tests/spec2k/197.parser...
File tests/spec2k/197.parser/diff (right):

https://codereview.chromium.org/2244023002/diff/40001/tests/spec2k/197.parser...
tests/spec2k/197.parser/diff:9: int strncasecmp(const char *s1, const char *s2,
size_t);
On 2016/08/15 17:57:45, Derek Schuff wrote:
> This declaration is the same as the one for strncasecmp in strings.h. Is it
> necessary to ifdef the declaration too? i.e. can we get away with just
ifdefing
> the definition? (Or is emscripten's header declaration different?)

Done.

[Derek Schuff, 2016-08-17 06:13:46]

lgtm

[ddchen, 2016-08-19 01:10:42]

The CQ bit was checked by ddchen@chromium.org

[commit-bot: I haz the power, 2016-08-19 01:10:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 01:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 01:13:01]

Try jobs failed on following builders:
  nacl-presubmit on master.tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/797)

[Derek Schuff, 2016-08-19 16:31:07]

Description was changed from

==========
Fix bugs with SPEC2k for WebAssembly

BUG=
==========

to

==========
Fix bugs with SPEC2k for WebAssembly

NOPRESUBMIT=true
==========

[Derek Schuff, 2016-08-19 16:31:12]

The CQ bit was checked by dschuff@chromium.org

[Derek Schuff, 2016-08-19 16:31:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dschuff@chromium.org
Link to the patchset: https://codereview.chromium.org/2244023002/#ps100001
(title: "Fix 175.vpr command line float arguments as well")

[commit-bot: I haz the power, 2016-08-19 16:31:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ddchen, 2016-08-19 17:30:36]

The CQ bit was unchecked by ddchen@chromium.org

[ddchen, 2016-08-19 17:52:12]

On 2016/08/19 16:31:24, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

PTAL for 175.vpr.

[Derek Schuff, 2016-08-19 18:16:07]

On 2016/08/19 17:52:12, ddchen wrote:
> On 2016/08/19 16:31:24, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> PTAL for 175.vpr.

Ew, I'd forgotten about that bug. That's in sort of a different category of
"things that are bugs that we will fix, making this diff unnecessary" vs the
some of the others which are "things that are fundmamental limitations or design
decisions of wasm" (e.g. missing prototypes or function pointer types). Could
you maybe add a notation to the READMEs of the things that can be backed out
once we fix them?

[ddchen, 2016-08-19 22:01:18]

On 2016/08/19 18:16:07, Derek Schuff wrote:
> On 2016/08/19 17:52:12, ddchen wrote:
> > On 2016/08/19 16:31:24, commit-bot: I haz the power wrote:
> > > CQ is trying da patch. Follow status at
> > >  
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > 
> > PTAL for 175.vpr.
> 
> Ew, I'd forgotten about that bug. That's in sort of a different category of
> "things that are bugs that we will fix, making this diff unnecessary" vs the
> some of the others which are "things that are fundmamental limitations or
design
> decisions of wasm" (e.g. missing prototypes or function pointer types). Could
> you maybe add a notation to the READMEs of the things that can be backed out
> once we fix them?

I added a TODO for the 175.vpr diff.README.

[Derek Schuff, 2016-08-19 22:19:42]

The CQ bit was checked by dschuff@chromium.org

[Derek Schuff, 2016-08-19 22:19:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dschuff@chromium.org
Link to the patchset: https://codereview.chromium.org/2244023002/#ps120001
(title: "Add TODO for 175.vpr")

[commit-bot: I haz the power, 2016-08-19 22:19:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:14:04]

Description was changed from

==========
Fix bugs with SPEC2k for WebAssembly

NOPRESUBMIT=true
==========

to

==========
Fix bugs with SPEC2k for WebAssembly

NOPRESUBMIT=true

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/090f907ce...
==========

[commit-bot: I haz the power, 2016-08-19 23:14:05]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/native_client/src/native_client/+/090f907ce...