Materialized font style for TrayItemMore type system tray rows.

ash/common/system/tray/tray_popup_item_style.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_COMMON_SYSTEM_TRAY_TRAY_POPUP_ITEM_STYLE_H_
+#define ASH_COMMON_SYSTEM_TRAY_TRAY_POPUP_ITEM_STYLE_H_
+
+#include "base/observer_list.h"
+#include "third_party/skia/include/core/SkColor.h"
+
+namespace ui {
+class NativeTheme;
+}  // namespace ui
+
+namespace views {
+class Label;
+}  // namespace views
+
+namespace ash {
+class TrayPopupItemStyleObserver;
+
+// Central style provider for the system tray popup items. Makes it easier to

[tdanderson, 2016/09/12 18:51:47]

I'd prefer "rows", "system menu rows", or just "the system menu" rather than
"tray popup items". I'm also not super happy with having "tray popup" in the
class name but I'm OK with leaving that as-is and seeing how this class evolves
(e.g., it is likely this will be used for things other than the system menu,
such as the opt-in IME menu, notification center, etc)

[bruthig, 2016/09/15 18:56:30]

Done.  Let's discuss alternatives offline.

[tdanderson, 2016/09/15 19:49:33]

Acknowledged.

+// ensure all visuals are consistent and easily updated in one spot instead of
+// being defined in multiple places throughout the code.
+class TrayPopupItemStyle {
+ public:
+  // The different visual styles that a row can have.
+  enum class ColorStyle {
+    // Active and clickable

[tdanderson, 2016/09/12 18:51:47]

nit: . at end of comments

[bruthig, 2016/09/15 18:56:30]

Done.

+    ACTIVE,
+    // Inactive but clickable
+    INACTIVE,
+    // Disabled and not clickable
+    DISABLED,
+  };
+
+  // The different font styles that a row can have.
+  enum class FontStyle {

[tdanderson, 2016/09/12 18:51:47]

I'm having a hard time trying to figure out what all these are going to map to
based on the names. Maybe some re-naming or comments would be appropriate?

* TITLE: The text in the title row of the default views (i.e., the thing I'm
working on)?

* MAIN_PANEL_SECTION_ROW: The label for the default views. Perhaps call it
something like DEFAULT_VIEW_LABEL? Use of "panel" is not accurate since it's not
a panel.

* SUB_PANEL_SECTION_ROW: The label for the rows in the detailed views? (Wouldn't
they be the same as the above)? Same comment about renaming to something like
DETAILED_VIEW_LABEL or similar.

* SYSTEM_INFO: ?

* CAPTION: ?

* BUTTON: Is this the text used in text buttons (e.g., "Log out" in the top user
row)? What would you do in the case of the Cast row where there is a label *and*
a button, each possibly needing their own style?

[bruthig, 2016/09/15 18:56:30]

FTR I took this from the "System menu typography" section here:
https://folio.googleplex.com/cros-core-ui/spec#%2F2.1%20-%20System%20menu%20-...

On 2016/09/12 18:51:47, tdanderson wrote:
Done, re-named and added docs.  WDYT?
Apparently the default view items and the detailed view items are not the same.
Yes, this text is used for the 'Harmony' buttons, e.g. "Sign out", "Stop",
"Lock", etc.  For the cast row the "Casting to living room" text would use
MAIN_PANEL_SECTION_ROW and the "Stop" button would use BUTTON.

[tdanderson, 2016/09/15 19:49:33]

lg
Oh, strange. Thanks for clarifying.
Got it, thanks.

+    TITLE,
+    MAIN_PANEL_SECTION_ROW,
+    SUB_PANEL_SECTION_ROW,
+    SYSTEM_INFO,
+    CAPTION,
+    BUTTON,
+  };
+
+  TrayPopupItemStyle(const ui::NativeTheme* theme, FontStyle font_style);
+  virtual ~TrayPopupItemStyle();

[tdanderson, 2016/09/12 18:51:47]

should this actually be virtual?

[bruthig, 2016/09/15 18:56:30]

Removed.

+
+  void AddObserver(TrayPopupItemStyleObserver* observer);
+  void RemoveObserver(TrayPopupItemStyleObserver* observer);
+
+  const ui::NativeTheme* theme() const { return theme_; }
+
+  // Sets the |theme_| and notifies observers.
+  void SetTheme(const ui::NativeTheme* theme);
+
+  ColorStyle color_style() const { return color_style_; }
+
+  // Sets the |color_style_| and notifies observers if |color_style_| changed.
+  void SetColorStyle(ColorStyle color_style);
+
+  FontStyle font_style() const { return font_style_; }
+
+  // Sets the |font_style_| notifies observers if |font_style_| changed.
+  void SetFontStyle(FontStyle font_style);
+
+  SkColor GetForegroundColor() const;
+
+  // Configures a Label as per the style (e.g. color, font).
+  void SetupLabel(views::Label* label) const;
+
+ private:
+  void NotifyObserversStyleUpdated();
+
+  // The theme that the styles are dervied from.
+  const ui::NativeTheme* theme_;
+
+  FontStyle font_style_;
+
+  ColorStyle color_style_;
+
+  base::ObserverList<TrayPopupItemStyleObserver> observers_;
+};
+
+}  // namespace ash
+
+#endif  // ASH_COMMON_SYSTEM_TRAY_TRAY_POPUP_ITEM_STYLE_H_