Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: appengine/gce-backend/README.md

Issue 2243923002: Refactors GCE backend config updates. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/components/components/config/common_test.py ('k') | appengine/gce-backend/config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/gce-backend/README.md
diff --git a/appengine/gce-backend/README.md b/appengine/gce-backend/README.md
index 2b0b89ecf6ab33c0d88ddc6290f2c0e8a937af11..221a7b87cb319edcfefcf9fa3fd8f9d27ca21202 100644
--- a/appengine/gce-backend/README.md
+++ b/appengine/gce-backend/README.md
@@ -20,13 +20,9 @@ eventually consistent, converging on the desired state over multiple calls.
same name as pubsub.get\_machine\_provider\_subscription(). On the topic,
authorize the Machine Provider's default service account as a publisher,
e.g. machine-provider@appspot.gserviceaccount.com.
-* Store the following three entities in the datastore:
- * config.Configuration: Most of this entity will be updated by the app,
- but the config\_set field needs to be set to the name of the config set
- to fetch from the config service.
- * components.config.common.ConfigSettings: Set service\_hostname to the
- address of the config service, e.g. luci-config.appspot.com. All others
- fields are unused.
+* Use the ConfigApi to set the ConfigSettings datastore entity to the
+ address of the config service, e.g. luci-config.appspot.com.
+* Store the following entity in the datastore:
* components.machine\_provider.utils.MachineProviderConfiguration: Set
instance\_url to the URL for the Machine Provider service, e.g.
https://machine-provider.appspot.com.
@@ -47,7 +43,8 @@ service as templates.cfg and managers.cfg respectively.
Responsible for importing the current GCE configuration from the config service.
When a new config is detected, the local copy of the config in the datastore is
-updated.
+updated. This task ensures that the valid manager and template configurations
+are updated synchronously.
## process-config
« no previous file with comments | « appengine/components/components/config/common_test.py ('k') | appengine/gce-backend/config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698