chrome/installer/mac/app/AuthorizedInstall.h - Issue 2243863003: Added authorized install with a script to do the copy.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/AuthorizedInstall.h

Issue 2243863003: Added authorized install with a script to do the copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed to OO design Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_MAC_APP_AUTHORIZEDINSTALL_H_
	Anna Zeng 2016/08/18 15:57:16 Is there a test file for this new class? Let's add Is there a test file for this new class? Let's add that file in to this CL! ivanhernandez 2016/08/22 15:34:49 Will probably be on the next patch :) Show quoted text On 2016/08/18 15:57:16, Anna Zeng wrote: > Is there a test file for this new class? Let's add that file in to this CL! Will probably be on the next patch :)
	6 #define CHROME_INSTALLER_MAC_APP_AUTHORIZEDINSTALL_H_

	7

	8 #import <Foundation/Foundation.h>

	9 #import <Security/Security.h>

	10

	11 @interface AuthorizedInstall : NSObject {

	12 AuthorizationRef authRef_;

	13 OSStatus status_;

	14 FILE* communicationPipe_;
	Anna Zeng 2016/08/18 15:57:16 authRef_, status_, and communicationPipe_ can all authRef_, status_, and communicationPipe_ can all be local variables -- nobody else really needs to know about these instance variables! Let's make it happen. :D ivanhernandez 2016/08/22 15:34:49 Done. Show quoted text On 2016/08/18 15:57:16, Anna Zeng wrote: > authRef_, status_, and communicationPipe_ can all be local variables -- nobody > else really needs to know about these instance variables! Let's make it happen. > :D Done.
	15 }

	16

	17 // Asks for user password and starts tool with privileged permissions.

	18 - (BOOL)authorizeInstallationTool;
	Anna Zeng 2016/08/18 15:57:16 Can we make this the init function? Can we make this the init function? ivanhernandez 2016/08/22 15:34:49 Probably want to use a name other than init to bet Show quoted text On 2016/08/18 15:57:16, Anna Zeng wrote: > Can we make this the init function? Probably want to use a name other than init to better indicate what this method will do since it does a bit more than set up variables. Also changed the name to better reflect what it does.
	19

	20 // Allows this program to communicate with the child process.

	21 - (void)sendMessageToTool:(NSString*)message;
	Anna Zeng 2016/08/18 15:57:16 I think the preferred API is a function that doesn I think the preferred API is a function that doesn't take any parameters, but returns the path of the Chrome app in its final resting place. I also suggest that is what you change it to be. ivanhernandez 2016/08/22 15:34:49 Done. Show quoted text On 2016/08/18 15:57:16, Anna Zeng wrote: > I think the preferred API is a function that doesn't take any parameters, but > returns the path of the Chrome app in its final resting place. I also suggest > that is what you change it to be. Done.
	22

	23 @end

	24

	25 #endif // CHROME_INSTALLER_MAC_APP_AUTHORIZEDINSTALL_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/installer/mac/app/AuthorizedInstall.m » ('j') | chrome/installer/mac/app/AuthorizedInstall.m » ('J')