Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2243833002: Get rid of dead RemoveTemporary (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of dead RemoveTemporary kudos to marja@ for finding this BUG=v8:5209 Committed: https://crrev.com/0a93ebaa76e2834c2e2e5633beea1e9c5005cd9a Cr-Commit-Position: refs/heads/master@{#38619}

Patch Set 1 #

Patch Set 2 : Remove outdated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -39 lines) Patch
M src/ast/scopes.h View 1 2 chunks +1 line, -9 lines 0 comments Download
M src/ast/scopes.cc View 4 chunks +4 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-12 12:28:20 UTC) #2
neis
lgtm
4 years, 4 months ago (2016-08-12 12:31:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243833002/1
4 years, 4 months ago (2016-08-12 12:33:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243833002/20001
4 years, 4 months ago (2016-08-12 12:35:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 13:34:11 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 13:34:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a93ebaa76e2834c2e2e5633beea1e9c5005cd9a
Cr-Commit-Position: refs/heads/master@{#38619}

Powered by Google App Engine
This is Rietveld 408576698