webrtc/call/call.cc - Issue 2243823002: Added ProbeBitrate(bitrate_bps, num_probes) to BitrateProber.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/call.cc

Issue 2243823002: Added ProbeBitrate(bitrate_bps, num_probes) to BitrateProber. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Clean up api Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/call/call.cc

diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc

index f6354ade28e89e17037e9b03a3750058efc4b3fc..02cfc0c08046172129ea8feda33133037cb60b7f 100644

--- a/webrtc/call/call.cc

+++ b/webrtc/call/call.cc

@@ -593,8 +593,8 @@ void Call::SetBitrateConfig(

TRACE_EVENT0("webrtc", "Call::SetBitrateConfig");

RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());

RTC_DCHECK_GE(bitrate_config.min_bitrate_bps, 0);

- if (bitrate_config.max_bitrate_bps != -1)

- RTC_DCHECK_GT(bitrate_config.max_bitrate_bps, 0);

+ if (bitrate_config.max_bitrate_bps < -1)

+ return;

stefan-webrtc 2016/08/12 13:19:58 Is there a reason not to DCHECK?

philipel 2016/08/12 14:08:06 Thought this might be user input, but i haven't lo

if (config_.bitrate_config.min_bitrate_bps ==

bitrate_config.min_bitrate_bps &&

(bitrate_config.start_bitrate_bps <= 0 ||

« no previous file with comments | « no previous file | webrtc/modules/pacing/bitrate_prober.h » ('j') | webrtc/modules/pacing/bitrate_prober.h » ('J')