Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2243803002: [turbofan] Fix CheckedInt32Mod lowering for -0 case with negative left hand side. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix CheckedInt32Mod lowering for -0 case with negative left hand side. Properly deoptimize if the left hand side of a CheckedInt32Mod is negative and the result of the operation is zero. R=jarin@chromium.org BUG=v8:5286 Committed: https://crrev.com/665f0e40209744758d75ddb9f0ca1736947c34b5 Cr-Commit-Position: refs/heads/master@{#38615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -92 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 chunk +69 lines, -92 lines 0 comments Download
A test/mjsunit/regress/regress-5286.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-12 11:42:15 UTC) #1
Benedikt Meurer
Hey Jaro, Here's yet another minus zero. Please take a look. Thanks, Benedikt
4 years, 4 months ago (2016-08-12 11:42:51 UTC) #4
Jarin
lgtm
4 years, 4 months ago (2016-08-12 11:52:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243803002/1
4 years, 4 months ago (2016-08-12 11:53:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 12:13:44 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:13:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/665f0e40209744758d75ddb9f0ca1736947c34b5
Cr-Commit-Position: refs/heads/master@{#38615}

Powered by Google App Engine
This is Rietveld 408576698