Replace static_cast with safe casting methods

Replace static_cast with safe casting methods

Continue Julien's work on reducing static_cast for 3 most popular CSS
casts (CSSPrimitiveValue, CSSValueList and CSSImageValue).

BUG=269140
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155689

[Julien - ping for review, 2013-08-06 23:32:30]

lgtm

[commit-bot: I haz the power, 2013-08-06 23:32:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/22438008/1

[commit-bot: I haz the power, 2013-08-06 23:49:59]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[abinader, 2013-08-06 23:54:17]

On 2013/08/06 23:49:59, I haz the power (commit-bot) wrote:
> Retried try job too often on blink_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

Hmm, it says a bindings/ owner should lgtm as wel. Christophe? :-)

[abinader, 2013-08-06 23:54:40]

On 2013/08/06 23:54:17, abinader wrote:
> On 2013/08/06 23:49:59, I haz the power (commit-bot) wrote:
> > Retried try job too often on blink_presubmit for step(s) presubmit
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...
> 
> Hmm, it says a bindings/ owner should lgtm as wel. Christophe? :-)

Well*

[do-not-use, 2013-08-07 06:23:57]

On 2013/08/06 23:54:40, abinader wrote:
> On 2013/08/06 23:54:17, abinader wrote:
> > On 2013/08/06 23:49:59, I haz the power (commit-bot) wrote:
> > > Retried try job too often on blink_presubmit for step(s) presubmit
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...
> > 
> > Hmm, it says a bindings/ owner should lgtm as wel. Christophe? :-)
> 
> Well*

LGTM for bindings/

[commit-bot: I haz the power, 2013-08-07 11:43:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/22438008/1

[commit-bot: I haz the power, 2013-08-07 13:31:50]

Change committed as 155689

[f(malita), 2013-08-07 16:59:09]

On 2013/08/07 13:31:50, I haz the power (commit-bot) wrote:
> Change committed as 155689

Looks like this is triggering asserts for the following tests:

fast/hidpi/image-set-out-of-order.html
fast/hidpi/image-set-without-specified-width.html
virtual/gpu/fast/hidpi/image-set-out-of-order.html
virtual/gpu/fast/hidpi/image-set-without-specified-width.html


STDERR: ASSERTION FAILED: !value || value->isImageValue()
STDERR: ../../third_party/WebKit/Source/core/css/CSSImageValue.h(72) :
WebCore::CSSImageValue *WebCore::toCSSImageValue(WebCore::CSSValue *)
STDERR: 1   0x5ed7ab6c WebCore::toCSSImageValue(WebCore::CSSValue*)
STDERR: 2   0x5ed22d3f WebCore::StylePendingImage::data() const
STDERR: 3   0x60fdaad3 WebCore::StyleImage::operator==(WebCore::StyleImage
const&) const
STDERR: 4   0x60fd43c1 WebCore::ImageContentData::equals(WebCore::ContentData
const&) const
STDERR: 5   0x6102123b WebCore::operator==(WebCore::ContentData const&,
WebCore::ContentData const&)
STDERR: 6   0x6101e034
WebCore::StyleRareNonInheritedData::contentDataEquivalent(WebCore::StyleRareNonInheritedData
const&) const
STDERR: 7   0x6125ba5b
WebCore::RenderStyle::contentDataEquivalent(WebCore::RenderStyle const*) const
...

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...


PTAL.

[abinader, 2013-08-07 19:55:01]

On 2013/08/07 16:59:09, Florin Malita wrote:
> On 2013/08/07 13:31:50, I haz the power (commit-bot) wrote:
> > Change committed as 155689
> 
> Looks like this is triggering asserts for the following tests:
> 
> fast/hidpi/image-set-out-of-order.html
> fast/hidpi/image-set-without-specified-width.html
> virtual/gpu/fast/hidpi/image-set-out-of-order.html
> virtual/gpu/fast/hidpi/image-set-without-specified-width.html
> 
> 
> STDERR: ASSERTION FAILED: !value || value->isImageValue()
> STDERR: ../../third_party/WebKit/Source/core/css/CSSImageValue.h(72) :
> WebCore::CSSImageValue *WebCore::toCSSImageValue(WebCore::CSSValue *)
> STDERR: 1   0x5ed7ab6c WebCore::toCSSImageValue(WebCore::CSSValue*)
> STDERR: 2   0x5ed22d3f WebCore::StylePendingImage::data() const
> STDERR: 3   0x60fdaad3 WebCore::StyleImage::operator==(WebCore::StyleImage
> const&) const
> STDERR: 4   0x60fd43c1 WebCore::ImageContentData::equals(WebCore::ContentData
> const&) const
> STDERR: 5   0x6102123b WebCore::operator==(WebCore::ContentData const&,
> WebCore::ContentData const&)
> STDERR: 6   0x6101e034
>
WebCore::StyleRareNonInheritedData::contentDataEquivalent(WebCore::StyleRareNonInheritedData
> const&) const
> STDERR: 7   0x6125ba5b
> WebCore::RenderStyle::contentDataEquivalent(WebCore::RenderStyle const*) const
> ...
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%25...
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%25...
> 
> 
> PTAL.

This is now handled in
https://code.google.com/p/chromium/issues/detail?id=269627