Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1366 matching lines...) Expand 10 before | Expand all | Expand 10 after
1377 } 1377 }
1378 switch (property->kind()) { 1378 switch (property->kind()) {
1379 case ObjectLiteral::Property::CONSTANT: 1379 case ObjectLiteral::Property::CONSTANT:
1380 UNREACHABLE(); 1380 UNREACHABLE();
1381 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1381 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1382 DCHECK(!CompileTimeValue::IsCompileTimeValue(value)); 1382 DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
1383 // Fall through. 1383 // Fall through.
1384 case ObjectLiteral::Property::COMPUTED: 1384 case ObjectLiteral::Property::COMPUTED:
1385 // It is safe to use [[Put]] here because the boilerplate already 1385 // It is safe to use [[Put]] here because the boilerplate already
1386 // contains computed properties with an uninitialized value. 1386 // contains computed properties with an uninitialized value.
1387 if (key->IsPropertyName()) { 1387 if (key->IsStringLiteral()) {
1388 DCHECK(key->IsPropertyName());
1388 if (property->emit_store()) { 1389 if (property->emit_store()) {
1389 VisitForAccumulatorValue(value); 1390 VisitForAccumulatorValue(value);
1390 DCHECK(StoreDescriptor::ValueRegister().is(rax)); 1391 DCHECK(StoreDescriptor::ValueRegister().is(rax));
1391 __ Move(StoreDescriptor::NameRegister(), key->value()); 1392 __ Move(StoreDescriptor::NameRegister(), key->value());
1392 __ movp(StoreDescriptor::ReceiverRegister(), Operand(rsp, 0)); 1393 __ movp(StoreDescriptor::ReceiverRegister(), Operand(rsp, 0));
1393 EmitLoadStoreICSlot(property->GetSlot(0)); 1394 EmitLoadStoreICSlot(property->GetSlot(0));
1394 CallStoreIC(); 1395 CallStoreIC();
1395 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1396 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1396 1397
1397 if (NeedsHomeObject(value)) { 1398 if (NeedsHomeObject(value)) {
(...skipping 2264 matching lines...) Expand 10 before | Expand all | Expand 10 after
3662 DCHECK_EQ( 3663 DCHECK_EQ(
3663 isolate->builtins()->OnStackReplacement()->entry(), 3664 isolate->builtins()->OnStackReplacement()->entry(),
3664 Assembler::target_address_at(call_target_address, unoptimized_code)); 3665 Assembler::target_address_at(call_target_address, unoptimized_code));
3665 return ON_STACK_REPLACEMENT; 3666 return ON_STACK_REPLACEMENT;
3666 } 3667 }
3667 3668
3668 } // namespace internal 3669 } // namespace internal
3669 } // namespace v8 3670 } // namespace v8
3670 3671
3671 #endif // V8_TARGET_ARCH_X64 3672 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698