Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1334 matching lines...) Expand 10 before | Expand all | Expand 10 after
1345 } 1345 }
1346 switch (property->kind()) { 1346 switch (property->kind()) {
1347 case ObjectLiteral::Property::CONSTANT: 1347 case ObjectLiteral::Property::CONSTANT:
1348 UNREACHABLE(); 1348 UNREACHABLE();
1349 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1349 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1350 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1350 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1351 // Fall through. 1351 // Fall through.
1352 case ObjectLiteral::Property::COMPUTED: 1352 case ObjectLiteral::Property::COMPUTED:
1353 // It is safe to use [[Put]] here because the boilerplate already 1353 // It is safe to use [[Put]] here because the boilerplate already
1354 // contains computed properties with an uninitialized value. 1354 // contains computed properties with an uninitialized value.
1355 if (key->IsPropertyName()) { 1355 if (key->IsStringLiteral()) {
1356 DCHECK(key->IsPropertyName());
1356 if (property->emit_store()) { 1357 if (property->emit_store()) {
1357 VisitForAccumulatorValue(value); 1358 VisitForAccumulatorValue(value);
1358 DCHECK(StoreDescriptor::ValueRegister().is(r2)); 1359 DCHECK(StoreDescriptor::ValueRegister().is(r2));
1359 __ mov(StoreDescriptor::NameRegister(), Operand(key->value())); 1360 __ mov(StoreDescriptor::NameRegister(), Operand(key->value()));
1360 __ LoadP(StoreDescriptor::ReceiverRegister(), MemOperand(sp)); 1361 __ LoadP(StoreDescriptor::ReceiverRegister(), MemOperand(sp));
1361 EmitLoadStoreICSlot(property->GetSlot(0)); 1362 EmitLoadStoreICSlot(property->GetSlot(0));
1362 CallStoreIC(); 1363 CallStoreIC();
1363 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1364 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1364 1365
1365 if (NeedsHomeObject(value)) { 1366 if (NeedsHomeObject(value)) {
(...skipping 2307 matching lines...) Expand 10 before | Expand all | Expand 10 after
3673 DCHECK(kOSRBranchInstruction == br_instr); 3674 DCHECK(kOSRBranchInstruction == br_instr);
3674 3675
3675 DCHECK(interrupt_address == 3676 DCHECK(interrupt_address ==
3676 isolate->builtins()->OnStackReplacement()->entry()); 3677 isolate->builtins()->OnStackReplacement()->entry());
3677 return ON_STACK_REPLACEMENT; 3678 return ON_STACK_REPLACEMENT;
3678 } 3679 }
3679 3680
3680 } // namespace internal 3681 } // namespace internal
3681 } // namespace v8 3682 } // namespace v8
3682 #endif // V8_TARGET_ARCH_S390 3683 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698