Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1405 matching lines...) Expand 10 before | Expand all | Expand 10 after
1416 } 1416 }
1417 switch (property->kind()) { 1417 switch (property->kind()) {
1418 case ObjectLiteral::Property::CONSTANT: 1418 case ObjectLiteral::Property::CONSTANT:
1419 UNREACHABLE(); 1419 UNREACHABLE();
1420 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1420 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1421 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1421 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1422 // Fall through. 1422 // Fall through.
1423 case ObjectLiteral::Property::COMPUTED: 1423 case ObjectLiteral::Property::COMPUTED:
1424 // It is safe to use [[Put]] here because the boilerplate already 1424 // It is safe to use [[Put]] here because the boilerplate already
1425 // contains computed properties with an uninitialized value. 1425 // contains computed properties with an uninitialized value.
1426 if (key->IsPropertyName()) { 1426 if (key->IsStringLiteral()) {
1427 DCHECK(key->IsPropertyName());
1427 if (property->emit_store()) { 1428 if (property->emit_store()) {
1428 VisitForAccumulatorValue(value); 1429 VisitForAccumulatorValue(value);
1429 __ mov(StoreDescriptor::ValueRegister(), result_register()); 1430 __ mov(StoreDescriptor::ValueRegister(), result_register());
1430 DCHECK(StoreDescriptor::ValueRegister().is(a0)); 1431 DCHECK(StoreDescriptor::ValueRegister().is(a0));
1431 __ li(StoreDescriptor::NameRegister(), Operand(key->value())); 1432 __ li(StoreDescriptor::NameRegister(), Operand(key->value()));
1432 __ lw(StoreDescriptor::ReceiverRegister(), MemOperand(sp)); 1433 __ lw(StoreDescriptor::ReceiverRegister(), MemOperand(sp));
1433 EmitLoadStoreICSlot(property->GetSlot(0)); 1434 EmitLoadStoreICSlot(property->GetSlot(0));
1434 CallStoreIC(); 1435 CallStoreIC();
1435 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1436 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1436 1437
(...skipping 2342 matching lines...) Expand 10 before | Expand all | Expand 10 after
3779 reinterpret_cast<uint32_t>( 3780 reinterpret_cast<uint32_t>(
3780 isolate->builtins()->OnStackReplacement()->entry())); 3781 isolate->builtins()->OnStackReplacement()->entry()));
3781 return ON_STACK_REPLACEMENT; 3782 return ON_STACK_REPLACEMENT;
3782 } 3783 }
3783 3784
3784 3785
3785 } // namespace internal 3786 } // namespace internal
3786 } // namespace v8 3787 } // namespace v8
3787 3788
3788 #endif // V8_TARGET_ARCH_MIPS 3789 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698