Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1410 matching lines...) Expand 10 before | Expand all | Expand 10 after
1421 } 1421 }
1422 switch (property->kind()) { 1422 switch (property->kind()) {
1423 case ObjectLiteral::Property::CONSTANT: 1423 case ObjectLiteral::Property::CONSTANT:
1424 UNREACHABLE(); 1424 UNREACHABLE();
1425 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1425 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1426 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1426 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1427 // Fall through. 1427 // Fall through.
1428 case ObjectLiteral::Property::COMPUTED: 1428 case ObjectLiteral::Property::COMPUTED:
1429 // It is safe to use [[Put]] here because the boilerplate already 1429 // It is safe to use [[Put]] here because the boilerplate already
1430 // contains computed properties with an uninitialized value. 1430 // contains computed properties with an uninitialized value.
1431 if (key->IsPropertyName()) { 1431 if (key->IsStringLiteral()) {
1432 DCHECK(key->IsPropertyName());
1432 if (property->emit_store()) { 1433 if (property->emit_store()) {
1433 VisitForAccumulatorValue(value); 1434 VisitForAccumulatorValue(value);
1434 DCHECK(StoreDescriptor::ValueRegister().is(r0)); 1435 DCHECK(StoreDescriptor::ValueRegister().is(r0));
1435 __ mov(StoreDescriptor::NameRegister(), Operand(key->value())); 1436 __ mov(StoreDescriptor::NameRegister(), Operand(key->value()));
1436 __ ldr(StoreDescriptor::ReceiverRegister(), MemOperand(sp)); 1437 __ ldr(StoreDescriptor::ReceiverRegister(), MemOperand(sp));
1437 EmitLoadStoreICSlot(property->GetSlot(0)); 1438 EmitLoadStoreICSlot(property->GetSlot(0));
1438 CallStoreIC(); 1439 CallStoreIC();
1439 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1440 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1440 1441
1441 if (NeedsHomeObject(value)) { 1442 if (NeedsHomeObject(value)) {
(...skipping 2397 matching lines...) Expand 10 before | Expand all | Expand 10 after
3839 DCHECK(interrupt_address == 3840 DCHECK(interrupt_address ==
3840 isolate->builtins()->OnStackReplacement()->entry()); 3841 isolate->builtins()->OnStackReplacement()->entry());
3841 return ON_STACK_REPLACEMENT; 3842 return ON_STACK_REPLACEMENT;
3842 } 3843 }
3843 3844
3844 3845
3845 } // namespace internal 3846 } // namespace internal
3846 } // namespace v8 3847 } // namespace v8
3847 3848
3848 #endif // V8_TARGET_ARCH_ARM 3849 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698