Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2243773002: Add cipd recipe module to depot_tools (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes for pylint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2627 lines, -0 lines) Patch
A + recipe_modules/cipd/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A recipe_modules/cipd/api.py View 1 1 chunk +244 lines, -0 lines 0 comments Download
A recipe_modules/cipd/example.py View 1 chunk +115 lines, -0 lines 0 comments Download
A recipe_modules/cipd/example.expected/basic.json View 1 chunk +445 lines, -0 lines 0 comments Download
A recipe_modules/cipd/example.expected/describe-failed.json View 1 chunk +128 lines, -0 lines 0 comments Download
A recipe_modules/cipd/example.expected/describe-many-instances.json View 1 chunk +453 lines, -0 lines 0 comments Download
A recipe_modules/cipd/example.expected/install-failed.json View 1 chunk +31 lines, -0 lines 0 comments Download
A recipe_modules/cipd/example.expected/mac64.json View 1 chunk +445 lines, -0 lines 0 comments Download
A recipe_modules/cipd/example.expected/win64.json View 1 chunk +445 lines, -0 lines 0 comments Download
A recipe_modules/cipd/resources/bootstrap.py View 1 1 chunk +218 lines, -0 lines 0 comments Download
A recipe_modules/cipd/test_api.py View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-12 08:38:27 UTC) #2
emso
lgtm https://codereview.chromium.org/2243773002/diff/1/recipe_modules/cipd/api.py File recipe_modules/cipd/api.py (right): https://codereview.chromium.org/2243773002/diff/1/recipe_modules/cipd/api.py#newcode48 recipe_modules/cipd/api.py:48: # TODO(seanmccullough): clean up older CIPD installations. Is ...
4 years, 4 months ago (2016-08-12 09:17:09 UTC) #3
emso
lgtm to unblock you, but this should be reviewed by someone with more cipd knowledge
4 years, 4 months ago (2016-08-12 09:17:48 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/2243773002/diff/1/recipe_modules/cipd/api.py File recipe_modules/cipd/api.py (right): https://codereview.chromium.org/2243773002/diff/1/recipe_modules/cipd/api.py#newcode48 recipe_modules/cipd/api.py:48: # TODO(seanmccullough): clean up older CIPD installations. On 2016/08/12 ...
4 years, 4 months ago (2016-08-12 09:21:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243773002/1
4 years, 4 months ago (2016-08-12 09:21:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3096e3461c17b610)
4 years, 4 months ago (2016-08-12 09:27:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243773002/20001
4 years, 4 months ago (2016-08-12 09:32:26 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 09:35:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7929675b19082a...

Powered by Google App Engine
This is Rietveld 408576698