Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2369)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 2243753002: Prevent thread assertion for HTC mail apk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch that does not work. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index 0f8ca85b46b4b6dc8b195baf1c92a20f3a56962e..cecef14178fe5084bff8ee46f08d2a7049b41439 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -102,6 +102,8 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
private WebViewChromiumFactoryProvider mFactory;
+ private final boolean mShouldDisableThreadChecking;
+
private static boolean sRecordWholeDocumentEnabledByApi = false;
static void enableSlowWholeDocumentDraw() {
sRecordWholeDocumentEnabledByApi = true;
@@ -110,13 +112,14 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
// This does not touch any global / non-threadsafe state, but note that
// init is ofter called right after and is NOT threadsafe.
public WebViewChromium(WebViewChromiumFactoryProvider factory, WebView webView,
- WebView.PrivateAccess webViewPrivate) {
+ WebView.PrivateAccess webViewPrivate, boolean shouldDisableThreadChecking) {
mWebView = webView;
mWebViewPrivate = webViewPrivate;
mHitTestResult = new WebView.HitTestResult();
mContext = ResourcesContextWrapperFactory.get(mWebView.getContext());
mAppTargetSdkVersion = mContext.getApplicationInfo().targetSdkVersion;
mFactory = factory;
+ mShouldDisableThreadChecking = shouldDisableThreadChecking;
factory.getWebViewDelegate().addWebViewAssetPath(mWebView.getContext());
}
@@ -540,9 +543,21 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
mAwContents.loadDataWithBaseURL(baseUrl, data, mimeType, encoding, historyUrl);
}
- public void evaluateJavaScript(String script, ValueCallback<String> resultCallback) {
- checkThread();
- mAwContents.evaluateJavaScript(script, resultCallback);
+ @Override
+ public void evaluateJavaScript(
+ final String script, final ValueCallback<String> resultCallback) {
+ if (mShouldDisableThreadChecking && checkNeedsPost()) {
+ // This is a workaround for https://crbug.com/622151.
+ mFactory.addTask(new Runnable() {
+ @Override
+ public void run() {
+ mAwContents.evaluateJavaScript(script, resultCallback);
+ }
+ });
+ } else {
+ checkThread();
+ mAwContents.evaluateJavaScript(script, resultCallback);
+ }
}
@Override
@@ -2018,15 +2033,18 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
}
// Remove from superclass
+ @Override
public void preDispatchDraw(Canvas canvas) {
// TODO(leandrogracia): remove this method from WebViewProvider if we think
// we won't need it again.
}
+ @Override
public void onStartTemporaryDetach() {
mAwContents.onStartTemporaryDetach();
}
+ @Override
public void onFinishTemporaryDetach() {
mAwContents.onFinishTemporaryDetach();
}

Powered by Google App Engine
This is Rietveld 408576698