Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: dart/site/try/src/interaction_manager.dart

Issue 224373003: Detect concurrent edits. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/site/try/project_server.dart ('k') | dart/site/try/src/ui.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/site/try/src/interaction_manager.dart
diff --git a/dart/site/try/src/interaction_manager.dart b/dart/site/try/src/interaction_manager.dart
index b6c47b8dea52b49a7e6aae05424a65eb52c61f5e..44a910a9661ab3cec82cc1d784e357361e670304 100644
--- a/dart/site/try/src/interaction_manager.dart
+++ b/dart/site/try/src/interaction_manager.dart
@@ -34,7 +34,8 @@ import 'ui.dart' show
hackDiv,
mainEditorPane,
observer,
- outputDiv;
+ outputDiv,
+ statusDiv;
import 'decoration.dart' show
CodeCompletionDecoration,
@@ -96,6 +97,9 @@ abstract class InteractionManager {
/// Called when the user selected a new project file.
void onProjectFileSelected(String projectFile);
+
+ /// Called when notified about a project file changed (on the server).
+ void onProjectFileFsEvent(MessageEvent e);
}
/**
@@ -110,6 +114,8 @@ class InteractionContext extends InteractionManager {
// TODO(ahe): Don't use a fake unit.
new CompilationUnit('fake', '');
+ CompilationUnit lastSaved;
+
InteractionContext()
: super.internal() {
state = new InitialState(this);
@@ -134,6 +140,10 @@ class InteractionContext extends InteractionManager {
void onProjectFileSelected(String projectFile) {
return state.onProjectFileSelected(projectFile);
}
+
+ void onProjectFileFsEvent(MessageEvent e) {
+ return state.onProjectFileFsEvent(e);
+ }
}
abstract class InteractionState implements InteractionManager {
@@ -309,9 +319,11 @@ class InitialState extends InteractionState {
}
void postProjectFileUpdate(CompilationUnit unit) {
+ context.lastSaved = unit;
onError(ProgressEvent event) {
HttpRequest request = event.target;
- window.alert("Couldn't save '${unit.name}': ${request.responseText}");
+ statusDiv.text = "Couldn't save '${unit.name}': ${request.responseText}";
+ context.lastSaved = null;
}
new HttpRequest()
..open("POST", "/project/${unit.name}")
@@ -322,9 +334,7 @@ class InitialState extends InteractionState {
Future<List<String>> projectFileNames() {
return getString('project?list').then((String response) {
WebSocket socket = new WebSocket('ws://127.0.0.1:9090/ws/watch');
- socket.onMessage.listen((MessageEvent e) {
- print(e.data);
- });
+ socket.onMessage.listen(context.onProjectFileFsEvent);
return new List<String>.from(JSON.decode(response));
});
}
@@ -371,6 +381,22 @@ class InitialState extends InteractionState {
}
void transitionToInitialState() {}
+
+ void onProjectFileFsEvent(MessageEvent e) {
+ Map map = JSON.decode(e.data);
+ List modified = map['modify'];
+ if (modified == null) return;
+ for (String name in modified) {
+ if (context.lastSaved != null && context.lastSaved.name == name) {
+ context.lastSaved = null;
+ continue;
+ }
+ if (context.currentCompilationUnit.name == name) {
+ mainEditorPane.contentEditable = false;
+ statusDiv.text = 'Modified on disk';
+ }
+ }
+ }
}
Future<String> getString(uri) {
« no previous file with comments | « dart/site/try/project_server.dart ('k') | dart/site/try/src/ui.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698