Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2243713002: [tools/perf] Remove page_cycler benchmark and measurement (Closed)

Created:
4 years, 4 months ago by nednguyen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Remove page_cycler benchmarks and measurement These page_cycler benchmarks are superseded by the page_cycler_v2 benchmarks. BUG=611329 Committed: https://crrev.com/a8e83d9cc50f8a57c92a126d5a70280960c53fb4 Cr-Commit-Position: refs/heads/master@{#411582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -630 lines) Patch
D tools/perf/benchmarks/page_cycler.py View 1 chunk +0 lines, -159 lines 0 comments Download
D tools/perf/measurements/page_cycler.py View 1 chunk +0 lines, -179 lines 0 comments Download
D tools/perf/measurements/page_cycler_unittest.py View 1 chunk +0 lines, -292 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
nednguyen
4 years, 4 months ago (2016-08-12 00:40:33 UTC) #4
kouhei (in TOK)
lgtm!
4 years, 4 months ago (2016-08-12 01:14:03 UTC) #7
nednguyen
On 2016/08/12 01:14:03, kouhei wrote: > lgtm! I will wait for Ben to confirm before ...
4 years, 4 months ago (2016-08-12 01:18:07 UTC) #8
bccheng
On 2016/08/12 01:18:07, nednguyen (ooo til 8-13) wrote: > On 2016/08/12 01:14:03, kouhei wrote: > ...
4 years, 4 months ago (2016-08-12 03:31:28 UTC) #11
petrcermak
LGTM. Thanks, Petr
4 years, 4 months ago (2016-08-12 08:21:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243713002/1
4 years, 4 months ago (2016-08-12 08:29:29 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 08:32:25 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 08:33:47 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8e83d9cc50f8a57c92a126d5a70280960c53fb4
Cr-Commit-Position: refs/heads/master@{#411582}

Powered by Google App Engine
This is Rietveld 408576698