Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: media/renderers/renderer_impl.cc

Issue 2243683002: Add OnDurationChange() to RenderClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_player_simplified
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/renderer_impl.cc
diff --git a/media/renderers/renderer_impl.cc b/media/renderers/renderer_impl.cc
index 7381e94ef695c43036c62291bbbcb0f918057fa6..14ba2c8b8bb0c8151aa50af4bd4481ce0b13ec17 100644
--- a/media/renderers/renderer_impl.cc
+++ b/media/renderers/renderer_impl.cc
@@ -58,6 +58,13 @@ class RendererImpl::RendererClientInternal : public RendererClient {
DCHECK(type_ == DemuxerStream::VIDEO);
renderer_->OnVideoOpacityChange(opaque);
}
+ void OnDurationChange(base::TimeDelta duration) override {
+ // RendererClients should only be notified of duration changes in certain
+ // scenarios, none of which should arrise for RendererClientInternal.
watk 2016/08/12 00:49:06 arise
tguilbert 2016/08/12 00:58:15 Done.
+ // Duration changes should be sent to the pipeline by the DemuxerStream, via
+ // the DemuxerHost interface.
+ NOTREACHED();
+ }
private:
DemuxerStream::Type type_;

Powered by Google App Engine
This is Rietveld 408576698