Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: trunk/src/cc/layers/texture_layer.h

Issue 224363003: Re-land "cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/cc/layers/texture_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/cc/layers/texture_layer.h
===================================================================
--- trunk/src/cc/layers/texture_layer.h (revision 261488)
+++ trunk/src/cc/layers/texture_layer.h (working copy)
@@ -90,8 +90,20 @@
static scoped_refptr<TextureLayer> CreateForMailbox(
TextureLayerClient* client);
+ // Resets the client, which also resets the texture. This may synchronize with
+ // the impl thread if it is currently drawing a texture from the client, that
+ // was given via TextureLayerClient::PrepareTexture. After this call it is
+ // safe to destroy that texture. Note: it doesn't synchronize for mailboxes,
+ // those can only be destroyed after the release callback has been called.
void ClearClient();
+ // Resets the texture. This may synchronize with the impl thread if it is
+ // currently drawing a texture from the client, that was given via
+ // TextureLayerClient::PrepareTexture. After this call it is safe to destroy
+ // that texture. Note: it doesn't synchronize for mailboxes, those can only be
+ // destroyed after the release callback has been called.
+ void ClearTexture();
+
virtual scoped_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl)
OVERRIDE;
@@ -122,10 +134,6 @@
// Requires a non-nil client. Defaults to false.
void SetRateLimitContext(bool rate_limit);
- // Code path for plugins which supply their own texture ID.
- // DEPRECATED. DO NOT USE.
- void SetTextureId(unsigned texture_id);
-
// Code path for plugins which supply their own mailbox.
bool uses_mailbox() const { return uses_mailbox_; }
void SetTextureMailbox(const TextureMailbox& mailbox,
@@ -137,8 +145,6 @@
// TODO(danakj): Remove this when pepper doesn't need it. crbug.com/350204
void SetTextureMailboxWithoutReleaseCallback(const TextureMailbox& mailbox);
- void WillModifyTexture();
-
virtual void SetNeedsDisplayRect(const gfx::RectF& dirty_rect) OVERRIDE;
virtual void SetLayerTreeHost(LayerTreeHost* layer_tree_host) OVERRIDE;
@@ -170,7 +176,7 @@
bool premultiplied_alpha_;
bool blend_background_color_;
bool rate_limit_context_;
- bool content_committed_;
+ bool impl_may_draw_client_data_;
unsigned texture_id_;
scoped_ptr<TextureMailboxHolder::MainThreadReference> holder_ref_;
« no previous file with comments | « no previous file | trunk/src/cc/layers/texture_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698