Split fpdfsdk/fsdk_annothandler.h into individual classes.

Split fpdfsdk/fsdk_annothandler.h into individual classes.

This CL moves classes in fsdk_annothandler.h, which are
CPDFSDK_AnnotIterator, CPDFSDK_AnnotHandlerMgr, IPDFSDK_AnnotHandler,
CPDFSDK_XFAAnnotHandler and CPDFSDK_BFAnnotHandler, to their own files.

Committed: https://pdfium.googlesource.com/pdfium/+/98e10199db97c8cae846cb2c0c571bda5033f61a

[jaepark, 2016-08-11 20:35:44]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 20:35:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaepark, 2016-08-11 20:36:16]

The CQ bit was unchecked by jaepark@google.com

[jaepark, 2016-08-11 20:38:58]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[jaepark, 2016-08-11 20:39:02]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-11 20:39:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:54:46]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-11 20:58:31]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 20:58:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaepark, 2016-08-11 20:58:46]

Patchset #1 (id:20001) has been deleted

[jaepark, 2016-08-11 21:15:24]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 21:15:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaepark, 2016-08-11 21:15:30]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-08-11 21:32:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:32:10]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-11 21:40:43]

jaepark@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-08-12 03:02:50]

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_annotit...
File fpdfsdk/cpdfsdk_annotiterator.cpp (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_annotit...
fpdfsdk/cpdfsdk_annotiterator.cpp:1: // Copyright 2014 PDFium Authors. All
rights reserved.
nit: 2016

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
File fpdfsdk/cpdfsdk_bfannothandler.cpp (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:1: // Copyright 2014 PDFium Authors. All
rights reserved.
nit: 2016

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:131: if (sSubType == BFFT_SIGNATURE) {
negate and move the else in here.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:143: if (sSubType == BFFT_SIGNATURE) {
negate this and move the else in here.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:156: if (sSubType == BFFT_SIGNATURE) {
ditto

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:171: if (sSubType == BFFT_SIGNATURE) {
ditto

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:186: if (sSubType == BFFT_SIGNATURE) {
ditto

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:202: } else {
ditto

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:217: if (sSubType == BFFT_SIGNATURE) {
ditto  (and others below)

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
File fpdfsdk/include/cpdfsdk_annothandlermgr.h (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
fpdfsdk/include/cpdfsdk_annothandlermgr.h:30: // Destroy the handler
Remove comment

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
File fpdfsdk/include/cpdfsdk_bfannothandler.h (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
fpdfsdk/include/cpdfsdk_bfannothandler.h:1: // Copyright 2014 PDFium Authors.
All rights reserved.
nit: 2016

[jaepark, 2016-08-12 17:52:46]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:52:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:05:45]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-12 18:09:35]

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_annotit...
File fpdfsdk/cpdfsdk_annotiterator.cpp (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_annotit...
fpdfsdk/cpdfsdk_annotiterator.cpp:1: // Copyright 2014 PDFium Authors. All
rights reserved.
On 2016/08/12 03:02:49, dsinclair wrote:
> nit: 2016

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
File fpdfsdk/cpdfsdk_bfannothandler.cpp (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:1: // Copyright 2014 PDFium Authors. All
rights reserved.
On 2016/08/12 03:02:49, dsinclair wrote:
> nit: 2016

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:131: if (sSubType == BFFT_SIGNATURE) {
On 2016/08/12 03:02:49, dsinclair wrote:
> negate and move the else in here.

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:143: if (sSubType == BFFT_SIGNATURE) {
On 2016/08/12 03:02:50, dsinclair wrote:
> negate this and move the else in here.

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:156: if (sSubType == BFFT_SIGNATURE) {
On 2016/08/12 03:02:49, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:171: if (sSubType == BFFT_SIGNATURE) {
On 2016/08/12 03:02:49, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:186: if (sSubType == BFFT_SIGNATURE) {
On 2016/08/12 03:02:49, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:202: } else {
On 2016/08/12 03:02:50, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:217: if (sSubType == BFFT_SIGNATURE) {
On 2016/08/12 03:02:49, dsinclair wrote:
> ditto  (and others below)

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
File fpdfsdk/include/cpdfsdk_annothandlermgr.h (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
fpdfsdk/include/cpdfsdk_annothandlermgr.h:30: // Destroy the handler
On 2016/08/12 03:02:50, dsinclair wrote:
> Remove comment

Done.

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
File fpdfsdk/include/cpdfsdk_bfannothandler.h (right):

https://codereview.chromium.org/2243623002/diff/60001/fpdfsdk/include/cpdfsdk...
fpdfsdk/include/cpdfsdk_bfannothandler.h:1: // Copyright 2014 PDFium Authors.
All rights reserved.
On 2016/08/12 03:02:50, dsinclair wrote:
> nit: 2016

Done.

[dsinclair, 2016-08-15 13:25:55]

https://codereview.chromium.org/2243623002/diff/80001/fpdfsdk/cpdfsdk_bfannot...
File fpdfsdk/cpdfsdk_bfannothandler.cpp (right):

https://codereview.chromium.org/2243623002/diff/80001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:129: CFX_ByteString sSubType =
pAnnot->GetSubType();
Looks like we don't need to store this, can just use pAnnot->GetSubType() in the
if below

https://codereview.chromium.org/2243623002/diff/80001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:132: if (m_pFormFiller)
These could actually become:

if (sSubType != BFFT_SIGNATURE && m_pFormFiller) to get ride of the nested if
and {}'s

[jaepark, 2016-08-15 17:06:06]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 17:06:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-15 17:23:38]

lgtm

[commit-bot: I haz the power, 2016-08-15 17:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 17:49:13]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-15 17:50:43]

https://codereview.chromium.org/2243623002/diff/80001/fpdfsdk/cpdfsdk_bfannot...
File fpdfsdk/cpdfsdk_bfannothandler.cpp (right):

https://codereview.chromium.org/2243623002/diff/80001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:129: CFX_ByteString sSubType =
pAnnot->GetSubType();
On 2016/08/15 13:25:55, dsinclair wrote:
> Looks like we don't need to store this, can just use pAnnot->GetSubType() in
the
> if below

Done.

https://codereview.chromium.org/2243623002/diff/80001/fpdfsdk/cpdfsdk_bfannot...
fpdfsdk/cpdfsdk_bfannothandler.cpp:132: if (m_pFormFiller)
On 2016/08/15 13:25:55, dsinclair wrote:
> These could actually become:
> 
> if (sSubType != BFFT_SIGNATURE && m_pFormFiller) to get ride of the nested if
> and {}'s

Done.

[jaepark, 2016-08-15 17:50:49]

The CQ bit was checked by jaepark@google.com

[commit-bot: I haz the power, 2016-08-15 17:51:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 17:51:14]

Description was changed from

==========
Split fpdfsdk/fsdk_annothandler.h into individual classes.

This CL moves classes in fsdk_annothandler.h, which are
CPDFSDK_AnnotIterator, CPDFSDK_AnnotHandlerMgr, IPDFSDK_AnnotHandler,
CPDFSDK_XFAAnnotHandler and CPDFSDK_BFAnnotHandler, to their own files.
==========

to

==========
Split fpdfsdk/fsdk_annothandler.h into individual classes.

This CL moves classes in fsdk_annothandler.h, which are
CPDFSDK_AnnotIterator, CPDFSDK_AnnotHandlerMgr, IPDFSDK_AnnotHandler,
CPDFSDK_XFAAnnotHandler and CPDFSDK_BFAnnotHandler, to their own files.

Committed:
https://pdfium.googlesource.com/pdfium/+/98e10199db97c8cae846cb2c0c571bda5033...
==========

[commit-bot: I haz the power, 2016-08-15 17:51:15]

Committed patchset #3 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/98e10199db97c8cae846cb2c0c571bda5033...