Replace EntryArray type by an Entry[]

LayoutTests/fast/filesystem/resources/op-tests-helper.js

Index: LayoutTests/fast/filesystem/resources/op-tests-helper.js
diff --git a/LayoutTests/fast/filesystem/resources/op-tests-helper.js b/LayoutTests/fast/filesystem/resources/op-tests-helper.js
index 42e9ef5aea3768ca1118ab8eba4120fc3dd905b7..5eb0e579723609b7951bc677567b708ebc722dd9 100644
--- a/LayoutTests/fast/filesystem/resources/op-tests-helper.js
+++ b/LayoutTests/fast/filesystem/resources/op-tests-helper.js
@@ -207,8 +207,7 @@ function runOperationTest(fileSystem, testCase, successCallback, errorCallback)
             if (this.expectedErrorCode)
                 testFailed('Unexpectedly succeeded while ' + this.stage);
 
-            for (var i = 0; i < entries.length; ++i)
-                this.readEntries.push(entries[i]);
+            this.readEntries = this.readEntries.concat(entries);

[arv (Not doing code reviews), 2013/08/07 14:24:43]

concat is evil. How about:

this.readEntries.push.apply(this.readEntries, entries);

[apavlov, 2013/08/07 14:29:28]

On a related note, we on the DevTools team have seen V8 stack overflows with
push.apply if |entries| is _sufficiently_ long...

[do-not-use, 2013/08/07 18:12:29]

Honestly, as a non-javascript person, it is really not obvious what this line is
doing. I find the concat() to be much more readable (not to say that it is
better / not evil).

 
             if (entries.length) {
                 this.currentReader.readEntries(bindCallback(this, this.testReadEntriesSuccessCallback), bindCallback(this, this.testErrorCallback));