Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2243563002: Show small notification icons in notification tray (reland) (Closed)

Created:
4 years, 4 months ago by yoshiki
Modified:
4 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show small notification icons in notification tray (reland) This patch is a reland of crrev.com/411019 with fixing the memory leak by moving the place of AddChild(count_label_view). Original Description: This patch shows small notification icons (up to 3) of the current notifications in the notification tray. This also makes the counter show the count of all the notification excluding the visible small icons (previously it was the unread count). See the issue for screenshots. BUG=633399 TEST=manual test (with and without MD mode) R=xiyuan@chromuim.org TBR=oshima@chromium.org Committed: https://crrev.com/79c70981ab68a0e4667493ab05a411d4c1f0dd24 Cr-Commit-Position: refs/heads/master@{#411418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -69 lines) Patch
M ash/common/system/tray/tray_background_view.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M ash/common/system/web_notification/web_notification_tray.h View 5 chunks +14 lines, -3 lines 0 comments Download
M ash/common/system/web_notification/web_notification_tray.cc View 10 chunks +228 lines, -64 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yoshiki
Xiyuan, PTAL. The difference from the original patch is only the place of AddChild(counter_label_view). I ...
4 years, 4 months ago (2016-08-11 18:27:04 UTC) #5
xiyuan
lgtm
4 years, 4 months ago (2016-08-11 20:02:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243563002/1
4 years, 4 months ago (2016-08-11 20:54:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 20:59:57 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 21:01:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79c70981ab68a0e4667493ab05a411d4c1f0dd24
Cr-Commit-Position: refs/heads/master@{#411418}

Powered by Google App Engine
This is Rietveld 408576698