Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2243533002: Revert of Revert renderer IPC::Channel acquisition via shell connection (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert renderer IPC::Channel acquisition via shell connection (patchset #2 id:20001 of https://codereview.chromium.org/2238633003/ ) Reason for revert: Essentially relanding the new bootstrap behavior since it apparently wasn't the cause of breakage. Original issue's description: > Revert renderer IPC::Channel acquisition via shell connection > > This may be causing failures in some test environments. Reverting > for now until there's more time to investigate. > > This CL effectively reverts a subset of > ff1b853cb6bfc3d5402fc970b2d856cbe73418cc. > > BUG=636624 > TBR=ben@chromium.org > > Committed: https://crrev.com/fd446c5a79522af111bb141559132893d85b60f8 > Cr-Commit-Position: refs/heads/master@{#411234} TBR=ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636624 Committed: https://crrev.com/04c007563350a80e8c64bb9b23b24f7bcb3dab10 Cr-Commit-Position: refs/heads/master@{#411371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Revert renderer IPC::Channel acquisition via shell connection
4 years, 4 months ago (2016-08-11 17:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243533002/1
4 years, 4 months ago (2016-08-11 17:54:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 17:54:53 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 17:57:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04c007563350a80e8c64bb9b23b24f7bcb3dab10
Cr-Commit-Position: refs/heads/master@{#411371}

Powered by Google App Engine
This is Rietveld 408576698