Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2243513003: [LayoutNG] Add tests for ng_length_utils. (Closed)

Created:
4 years, 4 months ago by ikilpatrick
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add tests for ng_length_utils. Also respects fixed size on constraint space. BUG=635619 Committed: https://crrev.com/5424fcdd1fd7d64e8595ae483125debfee80fbee Cr-Commit-Position: refs/heads/master@{#411447}

Patch Set 1 #

Patch Set 2 : [LayoutNG] Add tests for ng_length_utils. #

Patch Set 3 : address comments. #

Patch Set 4 : . #

Total comments: 11

Patch Set 5 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -32 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 2 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 2 3 1 chunk +41 lines, -22 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 2 3 4 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
ikilpatrick
4 years, 4 months ago (2016-08-11 19:22:39 UTC) #5
eae
LGTM
4 years, 4 months ago (2016-08-11 19:26:36 UTC) #6
cbiesinger
https://codereview.chromium.org/2243513003/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right): https://codereview.chromium.org/2243513003/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc#newcode52 third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:52: return constraintSpace.inlineContainerSize(); Thanks! https://codereview.chromium.org/2243513003/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc (right): https://codereview.chromium.org/2243513003/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc#newcode24 third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc:24: ...
4 years, 4 months ago (2016-08-11 20:41:57 UTC) #9
ikilpatrick
https://codereview.chromium.org/2243513003/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc File third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc (right): https://codereview.chromium.org/2243513003/diff/60001/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc#newcode24 third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc:24: LengthResolveType type = LengthResolveType::MinSize) { On 2016/08/11 20:41:57, cbiesinger ...
4 years, 4 months ago (2016-08-11 21:38:37 UTC) #10
cbiesinger
lgtm
4 years, 4 months ago (2016-08-11 21:40:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243513003/80001
4 years, 4 months ago (2016-08-11 21:52:56 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-11 23:42:18 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:45:39 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5424fcdd1fd7d64e8595ae483125debfee80fbee
Cr-Commit-Position: refs/heads/master@{#411447}

Powered by Google App Engine
This is Rietveld 408576698