Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2243503002: Actually register the BroadcastChannel pre-finalizer. (Closed)

Created:
4 years, 4 months ago by Marijn Kruisselbrink
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually register the BroadcastChannel pre-finalizer. BroadcastChannel defined a pre-finalizer, but never registered it, so the finalizer was never being called. This fixes crashes caused by that. BUG=635577 Committed: https://crrev.com/c48d361b1a4271a871418b7f73029c8e831e45be Cr-Commit-Position: refs/heads/master@{#411521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Marijn Kruisselbrink
4 years, 4 months ago (2016-08-11 17:29:31 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-12 00:16:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243503002/1
4 years, 4 months ago (2016-08-12 02:11:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 02:15:11 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 02:16:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c48d361b1a4271a871418b7f73029c8e831e45be
Cr-Commit-Position: refs/heads/master@{#411521}

Powered by Google App Engine
This is Rietveld 408576698