Issue 2243493002: Rewrite SdkExtUriResolver into reflective.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2243493002: Rewrite SdkExtUriResolver into reflective. (Closed)

Created:
4 years, 4 months ago by scheglov

Modified:
4 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -67 lines)			Patch
	M	pkg/analyzer/test/source/sdk_ext_test.dart	View		1 chunk	+65 lines, -67 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

lgtm, but my goal is to deprecate that class, so the tests will eventually go ...

4 years, 4 months ago (2016-08-11 16:23:25 UTC) #2

scheglov

4 years, 4 months ago (2016-08-11 16:29:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18b6c12f6129022e51b1e46c65969ebd77bb9c3c (presubmit successful).