Add LogDog stream name normalization function.

Add LogDog stream name normalization function.

Add a LogDog stream normalization function. This will take an arbitrary
stream name and make a best-effort attempt to convert it to a valid
LogDog stream name.

BUG=chromium:628770
TEST=unittest
  - Unit test for the new function runs successfully.

Committed: https://github.com/luci/luci-py/commit/6a5120210cd8214bcbaec031333e3148520d57df

[dnj, 2016-08-11 20:17:55]

dnj@chromium.org changed reviewers:
+ martiniss@chromium.org

[dnj, 2016-08-11 20:17:55]

PTAL

[martiniss, 2016-08-11 20:24:43]

lgtm

https://codereview.chromium.org/2243483003/diff/20001/client/libs/logdog/stre...
File client/libs/logdog/streamname.py (right):

https://codereview.chromium.org/2243483003/diff/20001/client/libs/logdog/stre...
client/libs/logdog/streamname.py:75: out.append(prefix)
Doing iteration over every character in a string like this, and appending to a
new list isn't the most efficient. This isn't on any super critical path though
AFAIK, so it should be fine.

https://codereview.chromium.org/2243483003/diff/20001/client/libs/logdog/stre...
client/libs/logdog/streamname.py:99: if ((ch_ord >= ord('0') and ch_ord <=
ord('9')) or
Why not use https://docs.python.org/2/library/string.html#string-constants ?

[dnj, 2016-08-11 20:42:29]

https://codereview.chromium.org/2243483003/diff/20001/client/libs/logdog/stre...
File client/libs/logdog/streamname.py (right):

https://codereview.chromium.org/2243483003/diff/20001/client/libs/logdog/stre...
client/libs/logdog/streamname.py:75: out.append(prefix)
On 2016/08/11 20:24:43, martiniss wrote:
> Doing iteration over every character in a string like this, and appending to a
> new list isn't the most efficient. This isn't on any super critical path
though
> AFAIK, so it should be fine.

If you know a better way to do this, LMK.

https://codereview.chromium.org/2243483003/diff/20001/client/libs/logdog/stre...
client/libs/logdog/streamname.py:99: if ((ch_ord >= ord('0') and ch_ord <=
ord('9')) or
On 2016/08/11 20:24:43, martiniss wrote:
> Why not use https://docs.python.org/2/library/string.html#string-constants ?

This seems faster, but might as well.

[dnj, 2016-08-11 21:19:51]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-08-11 21:19:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2243483003/#ps40001
(title: "Use string constants.")

[commit-bot: I haz the power, 2016-08-11 21:20:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:22:59]

Description was changed from

==========
Add LogDog stream name normalization function.

Add a LogDog stream normalization function. This will take an arbitrary
stream name and make a best-effort attempt to convert it to a valid
LogDog stream name.

BUG=chromium:628770
TEST=unittest
  - Unit test for the new function runs successfully.
==========

to

==========
Add LogDog stream name normalization function.

Add a LogDog stream normalization function. This will take an arbitrary
stream name and make a best-effort attempt to convert it to a valid
LogDog stream name.

BUG=chromium:628770
TEST=unittest
  - Unit test for the new function runs successfully.

Committed:
https://github.com/luci/luci-py/commit/6a5120210cd8214bcbaec031333e3148520d57df
==========

[commit-bot: I haz the power, 2016-08-11 21:23:00]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/6a5120210cd8214bcbaec031333e3148520d57df