Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
index 8b5892229a9919dc173917c16384231f1a0d6e78..3d5d3a572a5c27668887bc46d2595e967279e037 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
@@ -86,6 +86,14 @@ public:
// Notify us that the media element's network state has changed.
void networkStateChanged();
+ void toggleOverflowMenu();
+
+ bool overflowMenuVisible();
+
+ // Returns a list of all possible controls that can appear in an overflow
+ // menu
whywhat 2016/08/19 23:56:55 nit: end sentences with a dot, please
kdsilva 2016/08/24 05:33:27 Done.
+ std::vector<MediaControlInputElement*> getOverflowMenuButtons();
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -143,6 +151,13 @@ private:
Member<MediaControlVolumeSliderElement> m_volumeSlider;
Member<MediaControlToggleClosedCaptionsButtonElement> m_toggleClosedCaptionsButton;
Member<MediaControlTextTrackListElement> m_textTrackList;
+ Member<MediaControlOverflowMenu> m_overflowMenu;
+ Member<MediaControlOverflowMenuListElement> m_overflowList;
+ Member<MediaControlMuteButtonElement> m_muteOverflowButton;
+ Member<MediaControlCastButtonElement> m_castOverflowButton;
+ Member<MediaControlToggleClosedCaptionsButtonElement> m_ClosedCaptionsOverflowButton;
whywhat 2016/08/19 23:56:55 nit: s/Closed/closed
kdsilva 2016/08/24 05:33:27 Done.
+ Member<MediaControlFullscreenButtonElement> m_fullscreenOverflowButton;
+
Member<MediaControlCastButtonElement> m_castButton;
Member<MediaControlFullscreenButtonElement> m_fullScreenButton;

Powered by Google App Engine
This is Rietveld 408576698