Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
index c9aa995280ae8e19d2a823355e5b4e0ec8ad926f..f0652ad7b8717209912723009fe7b11782ad1d54 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
@@ -31,6 +31,7 @@
#define MediaControlElements_h
#include "core/html/shadow/MediaControlElementTypes.h"
+#include "public/platform/WebLocalizedString.h"
namespace blink {
@@ -94,6 +95,10 @@ public:
bool willRespondToMouseClickEvents() override { return true; }
void updateDisplayType() override;
+ WebLocalizedString::Name getOverflowStringName() override;
+
+ bool hasOverflowButton() override { return true; }
+
private:
explicit MediaControlMuteButtonElement(MediaControls&);
@@ -109,6 +114,10 @@ public:
bool willRespondToMouseClickEvents() override { return true; }
void updateDisplayType() override;
+ WebLocalizedString::Name getOverflowStringName() override;
+
+ bool hasOverflowButton() override { return true; }
+
private:
explicit MediaControlPlayButtonElement(MediaControls&);
@@ -140,6 +149,10 @@ public:
void updateDisplayType() override;
+ WebLocalizedString::Name getOverflowStringName() override;
+
+ bool hasOverflowButton() override { return true; }
+
private:
explicit MediaControlToggleClosedCaptionsButtonElement(MediaControls&);
@@ -173,6 +186,35 @@ private:
};
// ----------------------------
+// Represents the overflow menu which is displayed when the width of the media
+// player is small enough that at least two buttons are no longer visible.
+class MediaControlOverflowMenuButtonElement final : public MediaControlInputElement {
+public:
+ static MediaControlOverflowMenuButtonElement* create(MediaControls&);
+
+ // The overflow button should respond to mouse clicks since we want a click
+ // to open up the menu.
+ bool willRespondToMouseClickEvents() override { return true; }
+
+private:
+ explicit MediaControlOverflowMenuButtonElement(MediaControls&);
+
+ void defaultEventHandler(Event*) override;
+};
+
+// ----------------------------
+// Holds a list of elements within the overflow menu.
+class MediaControlOverflowMenuListElement final : public MediaControlDivElement {
+public:
+ static MediaControlOverflowMenuListElement* create(MediaControls&);
+
+private:
+ explicit MediaControlOverflowMenuListElement(MediaControls&);
+
+ void defaultEventHandler(Event*) override;
+};
+
+// ----------------------------
class MediaControlTimelineElement final : public MediaControlInputElement {
public:
@@ -202,6 +244,10 @@ public:
void setIsFullscreen(bool);
+ WebLocalizedString::Name getOverflowStringName() override;
+
+ bool hasOverflowButton() override { return true; }
+
private:
explicit MediaControlFullscreenButtonElement(MediaControls&);
@@ -218,6 +264,10 @@ public:
void setIsPlayingRemotely(bool);
+ WebLocalizedString::Name getOverflowStringName() override;
+
+ bool hasOverflowButton() override { return true; }
+
// This will show a cast button if it is not covered by another element.
// This MUST be called for cast button elements that are overlay elements.
void tryShowOverlay();

Powered by Google App Engine
This is Rietveld 408576698