Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
index bf8c0459b928958e840e38807573a6dc315950ad..7b3cb56bd34b823b2c7f678f2f789f2210cad641 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
@@ -300,6 +300,14 @@ void MediaControlMuteButtonElement::defaultEventHandler(Event* event)
void MediaControlMuteButtonElement::updateDisplayType()
{
setDisplayType(mediaElement().muted() ? MediaUnMuteButton : MediaMuteButton);
+ updateOverflowString();
+}
+
+WebLocalizedString::Name MediaControlMuteButtonElement::getOverflowStringName()
+{
+ if (mediaElement().muted())
+ return WebLocalizedString::OverflowMenuUnmute;
+ return WebLocalizedString::OverflowMenuMute;
}
// ----------------------------
@@ -342,6 +350,14 @@ void MediaControlPlayButtonElement::defaultEventHandler(Event* event)
void MediaControlPlayButtonElement::updateDisplayType()
{
setDisplayType(mediaElement().paused() ? MediaPlayButton : MediaPauseButton);
+ updateOverflowString();
+}
+
+WebLocalizedString::Name MediaControlPlayButtonElement::getOverflowStringName()
+{
+ if (mediaElement().paused())
+ return WebLocalizedString::OverflowMenuPlay;
+ return WebLocalizedString::OverflowMenuPause;
}
// ----------------------------
@@ -407,6 +423,10 @@ void MediaControlToggleClosedCaptionsButtonElement::updateDisplayType()
void MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler(Event* event)
{
if (event->type() == EventTypeNames::click) {
+ // If the user opens up the closed captions menu from the overfow menu,
+ // the overflow menu should no longer be visible.
+ if (mediaControls().overflowMenuVisible())
+ mediaControls().toggleOverflowMenu();
mediaControls().toggleTextTrackList();
updateDisplayType();
event->setDefaultHandled();
@@ -415,6 +435,11 @@ void MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler(Event* e
HTMLInputElement::defaultEventHandler(event);
}
+WebLocalizedString::Name MediaControlToggleClosedCaptionsButtonElement::getOverflowStringName()
+{
+ return WebLocalizedString::OverflowMenuCaptions;
+}
+
// ----------------------------
MediaControlTextTrackListElement::MediaControlTextTrackListElement(MediaControls& mediaControls)
@@ -554,6 +579,54 @@ void MediaControlTextTrackListElement::refreshTextTrackListMenu()
}
// ----------------------------
+MediaControlOverflowMenuButtonElement::MediaControlOverflowMenuButtonElement(MediaControls& mediaControls)
+ : MediaControlInputElement(mediaControls, MediaOverflowButton)
+{
+}
+
+MediaControlOverflowMenuButtonElement* MediaControlOverflowMenuButtonElement::create(MediaControls& mediaControls)
+{
+ MediaControlOverflowMenuButtonElement* button = new MediaControlOverflowMenuButtonElement(mediaControls);
+ button->ensureUserAgentShadowRoot();
+ button->setType(InputTypeNames::button);
+ button->setShadowPseudoId(AtomicString("-internal-overflow-menu-button"));
+ button->setIsWanted(false);
+ return button;
+}
+
+void MediaControlOverflowMenuButtonElement::defaultEventHandler(Event* event)
+{
+ if (event->type() == EventTypeNames::click) {
+ mediaControls().toggleOverflowMenu();
+ event->setDefaultHandled();
+ }
+
+ HTMLInputElement::defaultEventHandler(event);
+}
+
+// ----------------------------
+MediaControlOverflowMenuListElement::MediaControlOverflowMenuListElement(MediaControls& mediaControls)
+ : MediaControlDivElement(mediaControls, MediaOverflowList)
+{
+}
+
+MediaControlOverflowMenuListElement* MediaControlOverflowMenuListElement::create(MediaControls& mediaControls)
+{
+ MediaControlOverflowMenuListElement* element = new MediaControlOverflowMenuListElement(mediaControls);
+ element->setIsWanted(false);
+ element->setShadowPseudoId(AtomicString("-internal-media-controls-overflow-menu-list"));
+ return element;
+}
+
+void MediaControlOverflowMenuListElement::defaultEventHandler(Event* event)
+{
+ if (event->type() == EventTypeNames::click)
+ event->setDefaultHandled();
+
+ MediaControlDivElement::defaultEventHandler(event);
+}
+
+// ----------------------------
MediaControlTimelineElement::MediaControlTimelineElement(MediaControls& mediaControls)
: MediaControlInputElement(mediaControls, MediaSlider)
@@ -738,6 +811,13 @@ void MediaControlFullscreenButtonElement::setIsFullscreen(bool isFullscreen)
setDisplayType(isFullscreen ? MediaExitFullscreenButton : MediaEnterFullscreenButton);
}
+WebLocalizedString::Name MediaControlFullscreenButtonElement::getOverflowStringName()
+{
+ if (mediaElement().isFullscreen())
+ return WebLocalizedString::OverflowMenuExitFullscreen;
+ return WebLocalizedString::OverflowMenuEnterFullscreen;
+}
+
// ----------------------------
MediaControlCastButtonElement::MediaControlCastButtonElement(MediaControls& mediaControls, bool isOverlayButton)
@@ -799,6 +879,14 @@ void MediaControlCastButtonElement::setIsPlayingRemotely(bool isPlayingRemotely)
setDisplayType(MediaCastOffButton);
}
}
+ updateOverflowString();
+}
+
+WebLocalizedString::Name MediaControlCastButtonElement::getOverflowStringName()
+{
+ if (mediaElement().isPlayingRemotely())
+ return WebLocalizedString::OverflowMenuStopCast;
+ return WebLocalizedString::OverflowMenuCast;
}
void MediaControlCastButtonElement::tryShowOverlay()

Powered by Google App Engine
This is Rietveld 408576698