content/app/strings/content_strings.grd - Issue 2243473002: Adding overflow menu to media player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/app/strings/content_strings.grd

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added more tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/app/strings/content_strings.grd

diff --git a/content/app/strings/content_strings.grd b/content/app/strings/content_strings.grd

index 85c5354b4f196a8a99cdc0504ad554efe7a718d7..06de3c5cf08dd72aa9137e83279dfef3ba672fdb 100644

--- a/content/app/strings/content_strings.grd

+++ b/content/app/strings/content_strings.grd

@@ -856,6 +856,27 @@ below:

Please lengthen this text to <ph name="MIN_CHARACTERS">$2<ex>101</ex></ph> characters or more (you are currently using <ph name="CURRENT_LENGTH">$1<ex>100</ex></ph> characters).

</message>

+ <message name="IDS_AX_MEDIA_OVERFLOW_BUTTON" desc="Media controls overflow menu.">

+ Overflow menu

+ </message>

+ <message name="IDS_MEDIA_OVERFLOW_MENU_CAPTIONS" desc="Media controls overflow menu item label for a closed captions button.">

mlamouri (slow - plz ping) 2016/09/01 18:29:15 Should this be called IDS_MEDIA_OVERFLOW_MENU_CLOS

kdsilva 2016/09/05 14:39:35 Done.

+ Captions

mlamouri (slow - plz ping) 2016/09/01 18:29:15 I guess "Captions" is matching the UI specs? Maybe

kdsilva 2016/09/05 14:39:35 Done.

+ </message>

+ <message name="IDS_MEDIA_OVERFLOW_MENU_CAST" desc="Media controls overflow menu item label for a cast button.">

+ Cast

+ </message>

+ <message name="IDS_MEDIA_OVERFLOW_MENU_FULLSCREEN" desc="Media controls overflow menu item label for a fullscreen button.">

+ Fullscreen

+ </message>

+ <message name="IDS_MEDIA_OVERFLOW_MENU_STOP_CAST" desc="Media controls overflow menu item label for a button to stop casting.">

+ Stop casting

+ </message>

+ <message name="IDS_MEDIA_OVERFLOW_MENU_MUTE" desc="Media controls overflow menu item label for a mute button.">

+ Mute

+ </message>

+ <message name="IDS_MEDIA_OVERFLOW_MENU_UNMUTE" desc="Media controls overflow menu item label for an unmute button.">

+ Unmute

+ </message>

Unknown

</message>

« no previous file with comments | « no previous file | content/child/blink_platform_impl.cc » ('j') | third_party/WebKit/LayoutTests/media/display-overflow-menu.html » ('J')