third_party/WebKit/Source/core/css/CSSValueKeywords.in - Issue 2243473002: Adding overflow menu to media player

Side by Side Diff: third_party/WebKit/Source/core/css/CSSValueKeywords.in

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/css/mediaControlsNew.css » ('j') | third_party/WebKit/Source/core/css/mediaControlsNew.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 //	1 //

2 // CSS value names	2 // CSS value names

3 //	3 //

4	4

5 // The mode argument is used to limit the keyword to be used only for certain	5 // The mode argument is used to limit the keyword to be used only for certain

6 // CSSParserModes. Values that have the prefix -internal- are only allowed by	6 // CSSParserModes. Values that have the prefix -internal- are only allowed by

7 // CSSParserModes listed in allowInternalPropertyAndValue()	7 // CSSParserModes listed in allowInternalPropertyAndValue()

8	8

9 inherit	9 inherit

10 initial	10 initial

(...skipping 629 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
640 media-volume-sliderthumb	640 media-volume-sliderthumb

641 media-controls-background	641 media-controls-background

642 media-controls-fullscreen-background	642 media-controls-fullscreen-background

643 media-current-time-display	643 media-current-time-display

644 media-time-remaining-display	644 media-time-remaining-display

645 -internal-media-cast-off-button	645 -internal-media-cast-off-button

646 -internal-media-overlay-cast-off-button	646 -internal-media-overlay-cast-off-button

647 -internal-media-track-selection-checkmark	647 -internal-media-track-selection-checkmark

648 -internal-media-closed-captions-icon	648 -internal-media-closed-captions-icon

649 -internal-media-subtitles-icon	649 -internal-media-subtitles-icon

	650 media-overflow-menu-button
	whywhat 2016/08/19 23:56:55 why are there -internal and public keywords? is it why are there -internal and public keywords? is it related to whether the page can access the element using css? if so, we probably want the overflow button to be internal? kdsilva 2016/08/24 05:33:25 It's not obvious to me what the naming convention Show quoted text On 2016/08/19 23:56:55, whywhat wrote: > why are there -internal and public keywords? is it related to whether the page > can access the element using css? if so, we probably want the overflow button to > be internal? It's not obvious to me what the naming convention is for this file. For the media controls, I noticed that the all of the buttons in the media player were public (mute button, play button, closed captions button, etc) so that was my reasoning for making the overflow button public. Timothy Loh 2016/08/24 06:19:38 We can't just go and add whatever we want as web-e Show quoted text On 2016/08/24 05:33:25, kdsilva wrote: > On 2016/08/19 23:56:55, whywhat wrote: > > why are there -internal and public keywords? is it related to whether the page > > can access the element using css? if so, we probably want the overflow button > to > > be internal? > It's not obvious to me what the naming convention is for this file. For the > media controls, I noticed that the all of the buttons in the media player were > public (mute button, play button, closed captions button, etc) so that was my > reasoning for making the overflow button public. We can't just go and add whatever we want as web-exposed features. Making this -internal means that web devs can't set this value themselves. kdsilva 2016/08/26 18:11:02 Acknowledged. Show quoted text On 2016/08/24 06:19:38, Timothy Loh wrote: > On 2016/08/24 05:33:25, kdsilva wrote: > > On 2016/08/19 23:56:55, whywhat wrote: > > > why are there -internal and public keywords? is it related to whether the > page > > > can access the element using css? if so, we probably want the overflow > button > > to > > > be internal? > > It's not obvious to me what the naming convention is for this file. For the > > media controls, I noticed that the all of the buttons in the media player were > > public (mute button, play button, closed captions button, etc) so that was my > > reasoning for making the overflow button public. > > We can't just go and add whatever we want as web-exposed features. Making this > -internal means that web devs can't set this value themselves. Acknowledged.
650 menulist	651 menulist

651 menulist-button	652 menulist-button

652 menulist-text	653 menulist-text

653 menulist-textfield	654 menulist-textfield

654 meter	655 meter

655 progress-bar	656 progress-bar

656 progress-bar-value	657 progress-bar-value

657 slider-horizontal	658 slider-horizontal

658 slider-vertical	659 slider-vertical

659 sliderthumb-horizontal	660 sliderthumb-horizontal

(...skipping 428 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1088	1089

1089 var	1090 var

1090 -internal-variable-value	1091 -internal-variable-value

1091	1092

1092 // break-before, break-after, break-inside	1093 // break-before, break-after, break-inside

1093 avoid-page	1094 avoid-page

1094 page	1095 page

1095 recto	1096 recto

1096 verso	1097 verso

1097 avoid-column	1098 avoid-column

OLD	NEW