third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html - Issue 2243473002: Adding overflow menu to media player

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-fullscreen-button.html

Issue 2243473002: Adding overflow menu to media player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: small changes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/child/blink_platform_impl.cc ('K') | « third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-mute-button.html » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Clicking on the overflow fullscreen button opens the video in fullscreen. </title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-controls.js"></script>

	6 <script src="media-file.js"></script>

	7 <script src="overflow-menu.js"></script>

	8

	9 <!--Padding ensures the overflow menu is visible for the tests. -->

	10 <body style="padding-top: 200px; padding-left: 100px">

	11 <video controls></video>

	12 <script>

	13 async_test(function(t) {

	14 // Set up video

	15 var video = document.querySelector("video");

	16 video.src = findMediaFile("video", "content/test");

	17 video.setAttribute("width", "60");

	18 window.addEventListener("load", t.step_func(function() {

	19 var overflowList = getOverflowList(video);

	20 var overflowMenu = getOverflowMenuButton(video);

	21

	22 // Click on the overflow menu button

	23 var coords = elementCoordinates(overflowMenu);

	24 clickAtCoordinates(coords[0], coords[1]);

	25

	26 // Clicking on the fullscreen button should open up the video in fullscreen

	27 var coords = elementCoordinates(overflowList.children[OverflowMenuButtons.FU LLSCREEN]);

	28 clickAtCoordinates(coords[0], coords[1]);

	29

	30 video.onwebkitfullscreenchange = t.step_func(function() {
	mlamouri (slow - plz ping) 2016/09/07 09:07:54 This is still using the prefixed version. Can you This is still using the prefixed version. Can you do: ``` document.onfullscreenchange = t.step_func_done(() => { assert_equals(document.fullscreenElement, video); assert_equals(getComputedStyle(overflowMenu).display, "none"); }); ``` kdsilva 2016/09/07 11:01:09 Done. Show quoted text On 2016/09/07 09:07:54, mlamouri (slow) wrote: > This is still using the prefixed version. Can you do: > ``` > document.onfullscreenchange = t.step_func_done(() => { > assert_equals(document.fullscreenElement, video); > assert_equals(getComputedStyle(overflowMenu).display, "none"); > }); > ``` Done.
	31 // Overflow menu button should not be visible in fullscreen

	32 assert_equals(getComputedStyle(overflowMenu).display, "none");

	33 t.done();

	34 });

	35 }));

	36 });

	37 </script>

	38 </body>

OLD	NEW