net/socket/ssl_client_socket_impl.h - Issue 2243453002: Replace SSLProtocolNegotiation histogram with SSLNegotiatedAlpnProtocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_impl.h

Issue 2243453002: Replace SSLProtocolNegotiation histogram with SSLNegotiatedAlpnProtocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re: #24. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_impl.h

diff --git a/net/socket/ssl_client_socket_impl.h b/net/socket/ssl_client_socket_impl.h

index ccb780b5142879b6fe127fb85278388a33c8d9f3..017ff5854bc16e8c874e5955fd2afabdfb114170 100644

--- a/net/socket/ssl_client_socket_impl.h

+++ b/net/socket/ssl_client_socket_impl.h

@@ -240,9 +240,9 @@ class SSLClientSocketImpl : public SSLClientSocket {

void LogConnectEndEvent(int rv);

- // Record which TLS extension was used to negotiate protocol and protocol

- // chosen in a UMA histogram.

- void RecordNegotiationExtension() const;

+ // Record whether ALPN was used, and if so, the negotiated protocol,

+ // in a UMA histogram.

+ void RecordNegotiatedProtocol() const;

// Records histograms for channel id support during full handshakes - resumed

// handshakes are ignored.

« net/socket/next_proto.h ('K') | « net/socket/next_proto.h ('k') | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »