Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2243443005: Add check for mismatching item and document sequence numbers. (Closed)

Created:
4 years, 4 months ago by nasko
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add check for mismatching item and document sequence numbers. When a PageState update is received from the renderer process, it must be for the current session history entry. This means that the sequence numbers associated with the FrameNavigationEntry should match the ones coming from the renderer process. This CL adds a check for this case and drops the update if mismatch is found. BUG=628677 Review-Url: https://codereview.chromium.org/2196623003 Cr-Commit-Position: refs/heads/master@{#408698} (cherry picked from commit 3463467767b4dbd5b0e52a1a0001cd6fb8288be4) Committed: https://chromium.googlesource.com/chromium/src/+/f38836976725d366dbd0fb08054bea04f632ac59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
nasko
4 years, 4 months ago (2016-08-12 23:25:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f38836976725d366dbd0fb08054bea04f632ac59.

Powered by Google App Engine
This is Rietveld 408576698