Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 224343003: Enable supervised users password sync/import on ChromeOS (Closed)

Created:
6 years, 8 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 8 months ago
Reviewers:
stevenjb, Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Enable supervised users password sync/import on ChromeOS R=nkostylev@chromium.org TBR=stevenjb@chromium.org as owner of chromeos/cryptohome/* BUG=282464, 244472 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261792

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -32 lines) Patch
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_authentication.cc View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/chromeos/login/managed/supervised_user_creation_browsertest.cc View 1 9 chunks +17 lines, -14 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/cryptohome/mock_homedir_methods.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/cryptohome/mock_homedir_methods.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 8 months ago (2014-04-03 18:26:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/224343003/1
6 years, 8 months ago (2014-04-03 18:26:54 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/224343003/diff/1/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc File chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc (left): https://codereview.chromium.org/224343003/diff/1/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc#oldcode347 chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:347: if (!command_line->HasSwitch(::switches::kAllowCreateExistingManagedUsers)) Please remove switches::kAllowCreateExistingManagedUsers as well.
6 years, 8 months ago (2014-04-03 18:58:40 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 19:35:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-03 19:35:58 UTC) #5
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 8 months ago (2014-04-03 20:40:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/224343003/1
6 years, 8 months ago (2014-04-03 20:40:58 UTC) #7
commit-bot: I haz the power
Change committed as 261551
6 years, 8 months ago (2014-04-03 22:32:10 UTC) #8
Denis Kuznetsov (DE-MUC)
Please take another look.
6 years, 8 months ago (2014-04-04 15:21:13 UTC) #9
Nikita (slow)
lgtm
6 years, 8 months ago (2014-04-04 15:22:25 UTC) #10
Denis Kuznetsov (DE-MUC)
6 years, 8 months ago (2014-04-04 15:22:47 UTC) #11
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 8 months ago (2014-04-04 15:23:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/224343003/20001
6 years, 8 months ago (2014-04-04 15:23:46 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 18:22:44 UTC) #14
Message was sent while issue was closed. 
Change committed as 261792

Powered by Google App Engine
This is Rietveld 408576698