|
|
Chromium Code Reviews
Descriptionmac: Add a GPU power test for gifs.
BUG=616811
Committed: https://crrev.com/750b27bd5d7542ad84eb52adfacfba02616f0cfc
Cr-Commit-Position: refs/heads/master@{#413008}
Patch Set 1 #Patch Set 2 : Change gif. #Patch Set 3 : Try to upload binary. #Patch Set 4 : Use cloud storage for bunny gif. #
Messages
Total messages: 30 (19 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + nednguyen@google.com
nednguyen: Please review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
On 2016/08/17 23:32:28, erikchen wrote: > nednguyen: Please review. Where do you get this gif file from? Just want to make sure that we won't run to licensing issue in the future.
Description was changed from ========== mac: Add a GPU power test for gifs. BUG=616811 ========== to ========== mac: Add a GPU power test for gifs. BUG=616811 ==========
nednguyen@google.com changed reviewers: + charliea@chromium.org
On 2016/08/18 00:13:00, nednguyen wrote: > On 2016/08/17 23:32:28, erikchen wrote: > > nednguyen: Please review. > > Where do you get this gif file from? Just want to make sure that we won't run to > licensing issue in the future. For future power benchmarks, please also cc'ed Charlie
On 2016/08/18 00:13:34, nednguyen wrote: > On 2016/08/18 00:13:00, nednguyen wrote: > > On 2016/08/17 23:32:28, erikchen wrote: > > > nednguyen: Please review. > > > > Where do you get this gif file from? Just want to make sure that we won't run > to > > licensing issue in the future. > > For future power benchmarks, please also cc'ed Charlie Whoops. This came from http://giphy.com/gifs/black-and-white-OxTrfe9IyHVvi. And according to this article, is not available to use: https://www.quora.com/Do-I-have-the-right-to-use-a-GIF-that-I-find-at-Giphy-com (I searched for free gif, and clicked on the first result, which it would appear is not free-to-use gifs.).
nednguyen@google.com changed reviewers: + crouleau@chromium.org
On 2016/08/18 00:17:21, erikchen wrote: > On 2016/08/18 00:13:34, nednguyen wrote: > > On 2016/08/18 00:13:00, nednguyen wrote: > > > On 2016/08/17 23:32:28, erikchen wrote: > > > > nednguyen: Please review. > > > > > > Where do you get this gif file from? Just want to make sure that we won't > run > > to > > > licensing issue in the future. > > > > For future power benchmarks, please also cc'ed Charlie > > Whoops. > This came from http://giphy.com/gifs/black-and-white-OxTrfe9IyHVvi. > And according to this article, is not available to use: > https://www.quora.com/Do-I-have-the-right-to-use-a-GIF-that-I-find-at-Giphy-com > > (I searched for free gif, and clicked on the first result, which it would appear > is not free-to-use gifs.). +crouleau@: do you recommend any source of gifs for testing?
I would recommend taking this video: http://storage.googleapis.com/crouleau-shared/vids/h264.html (right click on the video, "save video as") and using one of the gif-makers webpages <https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=...> on it. Note that .gif and .gifv are very different. .gifv is just a normal video element under the hood. On Wed, Aug 17, 2016 at 5:19 PM, <nednguyen@google.com> wrote: > On 2016/08/18 00:17:21, erikchen wrote: > > On 2016/08/18 00:13:34, nednguyen wrote: > > > On 2016/08/18 00:13:00, nednguyen wrote: > > > > On 2016/08/17 23:32:28, erikchen wrote: > > > > > nednguyen: Please review. > > > > > > > > Where do you get this gif file from? Just want to make sure that we > won't > > run > > > to > > > > licensing issue in the future. > > > > > > For future power benchmarks, please also cc'ed Charlie > > > > Whoops. > > This came from http://giphy.com/gifs/black-and-white-OxTrfe9IyHVvi. > > And according to this article, is not available to use: > > > https://www.quora.com/Do-I-have-the-right-to-use-a-GIF- > that-I-find-at-Giphy-com > > > > (I searched for free gif, and clicked on the first result, which it would > appear > > is not free-to-use gifs.). > > +crouleau@: do you recommend any source of gifs for testing? > > https://codereview.chromium.org/2243403006/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The reason I recommend Blender's Big Buck Bunny is that they are cool with it: https://peach.blender.org/about/ That's why it's used for a lot of HTML5 video tests. On Wed, Aug 17, 2016 at 5:27 PM, Caleb Rouleau <crouleau@google.com> wrote: > I would recommend taking this video: http://storage. > googleapis.com/crouleau-shared/vids/h264.html (right click on the video, > "save video as") and using one of the gif-makers webpages > <https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=...> > on it. > > Note that .gif and .gifv are very different. .gifv is just a normal video > element under the hood. > > On Wed, Aug 17, 2016 at 5:19 PM, <nednguyen@google.com> wrote: > >> On 2016/08/18 00:17:21, erikchen wrote: >> > On 2016/08/18 00:13:34, nednguyen wrote: >> > > On 2016/08/18 00:13:00, nednguyen wrote: >> > > > On 2016/08/17 23:32:28, erikchen wrote: >> > > > > nednguyen: Please review. >> > > > >> > > > Where do you get this gif file from? Just want to make sure that we >> won't >> > run >> > > to >> > > > licensing issue in the future. >> > > >> > > For future power benchmarks, please also cc'ed Charlie >> > >> > Whoops. >> > This came from http://giphy.com/gifs/black-and-white-OxTrfe9IyHVvi. >> > And according to this article, is not available to use: >> > >> https://www.quora.com/Do-I-have-the-right-to-use-a-GIF-that- >> I-find-at-Giphy-com >> > >> > (I searched for free gif, and clicked on the first result, which it >> would >> appear >> > is not free-to-use gifs.). >> >> +crouleau@: do you recommend any source of gifs for testing? >> >> https://codereview.chromium.org/2243403006/ >> > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== mac: Add a GPU power test for gifs. BUG=616811 ========== to ========== mac: Add a GPU power test for gifs. BUG=616811 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== mac: Add a GPU power test for gifs. BUG=616811 ========== to ========== mac: Add a GPU power test for gifs. BUG=616811 Committed: https://crrev.com/750b27bd5d7542ad84eb52adfacfba02616f0cfc Cr-Commit-Position: refs/heads/master@{#413008} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/750b27bd5d7542ad84eb52adfacfba02616f0cfc Cr-Commit-Position: refs/heads/master@{#413008} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
