Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2243403006: mac: Add a GPU power test for gifs. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Add a GPU power test for gifs. BUG=616811 Committed: https://crrev.com/750b27bd5d7542ad84eb52adfacfba02616f0cfc Cr-Commit-Position: refs/heads/master@{#413008}

Patch Set 1 #

Patch Set 2 : Change gif. #

Patch Set 3 : Try to upload binary. #

Patch Set 4 : Use cloud storage for bunny gif. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M tools/perf/page_sets/mac_gpu_sites.py View 4 chunks +13 lines, -0 lines 0 comments Download
A tools/perf/page_sets/trivial_sites/bunny.gif.sha1 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + tools/perf/page_sets/trivial_sites/trivial_gif.html View 1 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 30 (19 generated)
erikchen
nednguyen: Please review.
4 years, 4 months ago (2016-08-17 23:32:28 UTC) #3
nednguyen
On 2016/08/17 23:32:28, erikchen wrote: > nednguyen: Please review. Where do you get this gif ...
4 years, 4 months ago (2016-08-18 00:13:00 UTC) #7
nednguyen
On 2016/08/18 00:13:00, nednguyen wrote: > On 2016/08/17 23:32:28, erikchen wrote: > > nednguyen: Please ...
4 years, 4 months ago (2016-08-18 00:13:34 UTC) #10
erikchen
On 2016/08/18 00:13:34, nednguyen wrote: > On 2016/08/18 00:13:00, nednguyen wrote: > > On 2016/08/17 ...
4 years, 4 months ago (2016-08-18 00:17:21 UTC) #11
nednguyen
On 2016/08/18 00:17:21, erikchen wrote: > On 2016/08/18 00:13:34, nednguyen wrote: > > On 2016/08/18 ...
4 years, 4 months ago (2016-08-18 00:19:54 UTC) #13
chromium-reviews
I would recommend taking this video: http://storage.googleapis.com/crouleau-shared/vids/h264.html (right click on the video, "save video as") ...
4 years, 4 months ago (2016-08-18 00:27:01 UTC) #14
chromium-reviews
The reason I recommend Blender's Big Buck Bunny is that they are cool with it: ...
4 years, 4 months ago (2016-08-18 00:29:07 UTC) #15
nednguyen
lgtm
4 years, 4 months ago (2016-08-19 00:13:18 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243403006/60001
4 years, 4 months ago (2016-08-19 00:18:25 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-19 01:34:13 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 01:38:20 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/750b27bd5d7542ad84eb52adfacfba02616f0cfc
Cr-Commit-Position: refs/heads/master@{#413008}

Powered by Google App Engine
This is Rietveld 408576698