Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2243393002: Revert of add parallel public API for recording SkLiteDL. (Closed)

Created:
4 years, 4 months ago by mtklein
Modified:
4 years, 4 months ago
Reviewers:
djsollen, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add parallel public API for recording SkLiteDL. (patchset #1 id:1 of https://codereview.chromium.org/2246893002/ ) Reason for revert: looking like we won't need this Original issue's description: > add parallel public API for recording SkLiteDL. > > The API is restricted to pretty much just what Derek calls, > but it's enough that we can switch testing over to use it. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246893002 > > Committed: https://skia.googlesource.com/skia/+/ced26a3d6b77d3a6744a8ccb8eff23eda45fc867 TBR=djsollen@google.com,reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8bbbb696cdc1351f615bc52ee119cfa384f77f30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -54 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +10 lines, -5 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of add parallel public API for recording SkLiteDL.
4 years, 4 months ago (2016-08-15 19:55:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243393002/1
4 years, 4 months ago (2016-08-15 19:55:56 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 19:56:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8bbbb696cdc1351f615bc52ee119cfa384f77f30

Powered by Google App Engine
This is Rietveld 408576698