Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2243343004: Revert of 🚀 Add dex info and static initializers to resource_sizes.py (Closed)

Created:
4 years, 4 months ago by amineer
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🚀 Add dex info and static initializers to resource_sizes.py (patchset #3 id:40001 of https://codereview.chromium.org/2244653003/ ) Reason for revert: Causing build failures, will update tracking bug with details. Original issue's description: > Add dex info and static initializers to resource_sizes.py > > The goal is to have a single script that reports all .apk > size related metrics. > > * Uses method_count.py to get dex info. > * Already had static initializer logic, but now shows it even without > --so_with_symbols_path. > * Tweaks the static initializer count logic to sum up rather for all > .so files rather than report the same metric repeatedly. > > BUG=609365 > > Committed: https://crrev.com/af1b0701484ff33965439440c43e620cf50a6056 > Cr-Commit-Position: refs/heads/master@{#411859} TBR=rnephew@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=609365 Committed: https://crrev.com/47fd25ce2fc9b8772836d2930de04ec4fa4edc8b Cr-Commit-Position: refs/heads/master@{#412064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -61 lines) Patch
M build/android/method_count.py View 5 chunks +8 lines, -8 lines 0 comments Download
M build/android/resource_sizes.py View 6 chunks +11 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
amineer
Created Revert of 🚀 Add dex info and static initializers to resource_sizes.py
4 years, 4 months ago (2016-08-15 21:02:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243343004/1
4 years, 4 months ago (2016-08-15 21:02:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 22:01:04 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47fd25ce2fc9b8772836d2930de04ec4fa4edc8b Cr-Commit-Position: refs/heads/master@{#412064}
4 years, 4 months ago (2016-08-15 22:06:24 UTC) #6
agrieve
4 years, 3 months ago (2016-08-31 17:57:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2294093006/ by agrieve@chromium.org.

The reason for reverting is: Will update description with reason for reland when
it's ready..

Powered by Google App Engine
This is Rietveld 408576698