Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2243223002: Quick View: Fix font size. (Closed)

Created:
4 years, 4 months ago by oka
Modified:
4 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, tienchang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: Fix font size. Current font size was too large. Fixed it accordingly to the discussion [1] with the designer. Demo (internal only): https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhRW9SRVBfSndjSms/view?usp=sharing [1] https://folio.googleplex.com/crosfilesapppreviewpane/High%20fidelity%20visuals/Quick%20View/Mocks%20&%20Specs/07_25_2016#%2FSPEC%20-%20Color%20scheme.png%3Fz=fit&c=show BUG=632726 TEST=manually confirmed the font sizes are 12.96px and 14px (13.9968px actually). Also confirmed font size changes when OS's default font size is changed from medium. Committed: https://crrev.com/a3659ee3e38860a16f9a0a0b74581d0f0c3a74ff Cr-Commit-Position: refs/heads/master@{#412441}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Add a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.html View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.css View 1 2 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243223002/1
4 years, 4 months ago (2016-08-16 23:06:30 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-16 23:06:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243223002/1
4 years, 4 months ago (2016-08-16 23:08:45 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-16 23:08:46 UTC) #8
oka
Fix
4 years, 4 months ago (2016-08-17 00:30:20 UTC) #9
oka
Add a comment.
4 years, 4 months ago (2016-08-17 00:33:48 UTC) #10
oka
PTAL.
4 years, 4 months ago (2016-08-17 00:41:25 UTC) #14
fukino
lgtm
4 years, 4 months ago (2016-08-17 02:06:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243223002/40001
4 years, 4 months ago (2016-08-17 02:17:19 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 03:39:28 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 03:41:22 UTC) #24
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a3659ee3e38860a16f9a0a0b74581d0f0c3a74ff
Cr-Commit-Position: refs/heads/master@{#412441}

Powered by Google App Engine
This is Rietveld 408576698