Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 22432006: content should be referring to the blink_test_plugin.gyp in the public directory. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

content should be referring to the blink_test_plugin.gyp in the public directory. content should not be of poking around the internal structure of Blink, instead it should just use things exposed through public. This is necessary because DumpRenderTree is going away soon. R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
7 years, 4 months ago (2013-08-09 13:21:39 UTC) #1
jochen (gone - plz use gerrit)
lgtm lgtm
7 years, 4 months ago (2013-08-09 13:25:27 UTC) #2
tfarina
7 years, 4 months ago (2013-08-10 02:16:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r216801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698