Web MIDI backend for Windows 10

media/midi/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
+import("//build/config/win/midi_winrt.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//media/media_options.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   # For generate_jni().
   import("//build/config/android/rules.gni")
 }
 
@@ skipping 56 matching lines @@
   }
 }
 
 component("midi") {
   sources = [
     "midi_export.h",
     "midi_manager.cc",
     "midi_manager.h",
     "midi_manager_mac.cc",
     "midi_manager_mac.h",
-    "midi_manager_win.cc",
-    "midi_manager_win.h",
     "midi_message_queue.cc",
     "midi_message_queue.h",
     "midi_message_util.cc",
     "midi_message_util.h",
     "midi_port_info.cc",
     "midi_port_info.h",
     "midi_scheduler.cc",
     "midi_scheduler.h",
     "midi_switches.cc",
     "midi_switches.h",
@@ skipping 37 matching lines @@
 
   if (is_mac) {
     libs += [
       "CoreAudio.framework",
       "CoreFoundation.framework",
       "CoreMIDI.framework",
     ]
   }
 
   if (is_win) {
     deps += [ "//device/usb" ]

[Takashi Toyoshima, 2016/08/15 08:46:23]

Hum... this line 140 might be an existing bug. I may miss something, but current
Windows backend does not depend on //device/usb.

This is not your fault, but could you check if we can compile without this line?

[Shao-Chuan Lee, 2016/08/16 07:42:24]

Will have it removed in another CL.

+    sources += [ "midi_manager_win.h" ]

[Takashi Toyoshima, 2016/08/15 08:46:23]

I think we should have a dedicated header, _winrt.h, for for your new
implementation.

[Shao-Chuan Lee, 2016/08/16 07:42:24]

Done.

+
+    if (midi_winrt) {
+      sources += [ "midi_manager_winrt.cc" ]
+      libs += [ "runtimeobject.lib" ]

[Takashi Toyoshima, 2016/08/15 08:46:23]

Can you add TODO(crbug.com/512433) with comments for the line 145?
This would be a simplified version of your note in the CL description.

[Shao-Chuan Lee, 2016/08/16 07:42:24]

Done.

+    } else {
+      sources += [ "midi_manager_win.cc" ]
+    }
   }
 
   if (use_alsa && use_udev) {
     deps += [
       "//crypto",
       "//crypto:platform",
     ]
     libs += [ "asound" ]
     sources += [
       "midi_manager_alsa.cc",
@@ skipping 40 matching lines @@
     sources += [ "midi_manager_alsa_unittest.cc" ]
   }
 
   if (use_x11) {
     deps += [ "//tools/xdisplaycheck" ]
   }
 
   # This target should not require the Chrome executable to run.
   assert_no_deps = [ "//chrome" ]
 }