build/config/win/midi_winrt.gni - Issue 2243183002: Web MIDI backend for Windows 10

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/win/midi_winrt.gni

Issue 2243183002: Web MIDI backend for Windows 10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 declare_args() {	5 declare_args() {

6 enable_leakcanary = false	6 midi_winrt = false
	Takashi Toyoshima 2016/08/15 08:46:23 Can you have this declaration in media/midi? See m Can you have this declaration in media/midi? See media/media_options.gni for examples for media. Adding new file as media/midi/midi_options.gni, or just writing directly into media/midi/BUILD.gn looks fine. Shao-Chuan Lee 2016/08/16 07:42:24 It looks like putting this in media/media_options. Show quoted text On 2016/08/15 08:46:23, toyoshim wrote: > Can you have this declaration in media/midi? > See media/media_options.gni for examples for media. > > Adding new file as media/midi/midi_options.gni, or just writing directly into > media/midi/BUILD.gn looks fine. It looks like putting this in media/media_options.gni is a good choice. Anyway this is temporary and should be removed upon merge.
7 }	7 }

OLD	NEW

« no previous file with comments | « no previous file | media/midi/BUILD.gn » ('j') | media/midi/BUILD.gn » ('J')